Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct the default filename of events-data #41808

Merged
merged 3 commits into from
Dec 12, 2024
Merged

Correct the default filename of events-data #41808

merged 3 commits into from
Dec 12, 2024

Conversation

f1tz
Copy link
Contributor

@f1tz f1tz commented Nov 27, 2024

Change 'event-data' to 'events-data' in the document.

Reference:

logfile = self.beat_name + "-events-data-" + self.today + ".ndjson"

glob := fmt.Sprintf("%s-events-data-%d*.ndjson", filepath.Join(b.tempDir, b.beatName), year)

@f1tz f1tz requested a review from a team as a code owner November 27, 2024 10:20
@f1tz f1tz requested review from AndersonQ and rdner and removed request for a team November 27, 2024 10:20
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Nov 27, 2024
Copy link

cla-checker-service bot commented Nov 27, 2024

💚 CLA has been signed

@mergify mergify bot assigned f1tz Nov 27, 2024
@pierrehilbert pierrehilbert added the Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team label Nov 27, 2024
@elasticmachine
Copy link
Collaborator

Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane)

@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Nov 27, 2024
@pierrehilbert
Copy link
Collaborator

Thanks @f1tz for your contribution.
Could you please sign our CLA?

@f1tz
Copy link
Contributor Author

f1tz commented Nov 27, 2024

Thanks @f1tz for your contribution. Could you please sign our CLA?

Thanks, I have already signed the CLA.

@rdner
Copy link
Member

rdner commented Dec 3, 2024

@f1tz thank you for your contribution!
Would you mind to fix the rest of the occurrences in this PR?

https://github.com/search?q=repo%3Aelastic%2Fbeats+-event-data&type=code

It would be nice to do that in one go, so all the docs are in sync. Thanks!

@belimawr as you worked on #38767, I think it might be a typo in the filename actually, not in the docs because all the config parameters have event_data in them.

What do you think we should fix here?

@belimawr
Copy link
Contributor

belimawr commented Dec 3, 2024

@belimawr as you worked on #38767, I think it might be a typo in the filename actually, not in the docs because all the config parameters have event_data in them.

What do you think we should fix here?

Yes, indeed it's a typo in the docs. I believe the only other file that needs updating is libbeat/_meta/config/logging.reference.yml.tmpl, the other configuration files are generated from it.

@belimawr belimawr self-requested a review December 3, 2024 22:24
@nimarezainia
Copy link
Contributor

@belimawr as you worked on #38767, I think it might be a typo in the filename actually, not in the docs because all the config parameters have event_data in them.
What do you think we should fix here?

Yes, indeed it's a typo in the docs. I believe the only other file that needs updating is libbeat/_meta/config/logging.reference.yml.tmpl, the other configuration files are generated from it.

@belimawr could you please open an issue with this detail so it can get addressed (fyi @kilfoyle )

@belimawr
Copy link
Contributor

belimawr commented Dec 3, 2024

@belimawr could you please open an issue with this detail so it can get addressed (fyi @kilfoyle )

@nimarezainia I believe this feature only documented here and in the Elastic-Agent standalone logging, so I just created the PR to fix it: elastic/ingest-docs#1520

@nimarezainia
Copy link
Contributor

@belimawr could you please open an issue with this detail so it can get addressed (fyi @kilfoyle )

@nimarezainia I believe this feature only documented here and in the Elastic-Agent standalone logging, so I just created the PR to fix it: elastic/ingest-docs#1520

thank you much appreciated,

@rdner
Copy link
Member

rdner commented Dec 10, 2024

@f1tz could you please update

#name: {{.BeatName}}-event-data
and then run make update in the root of the repository.

This should update all the occurrences of this typo. Thanks!

@rdner rdner requested review from a team as code owners December 10, 2024 16:37
@rdner rdner requested a review from a team as a code owner December 10, 2024 16:37
@rdner
Copy link
Member

rdner commented Dec 11, 2024

/test

@rdner rdner merged commit 9b66bb0 into elastic:8.16 Dec 12, 2024
142 checks passed
@rdner rdner added backport-8.15 Automated backport to the 8.15 branch with mergify backport-8.x Automated backport to the 8.x branch with mergify backport-8.16 Automated backport with mergify backport-8.17 Automated backport with mergify labels Dec 12, 2024
mergify bot pushed a commit that referenced this pull request Dec 12, 2024
* Update logging.reference.yml.tmpl
* Run `make update` to regenerate the docs

---------

Co-authored-by: Denis Rechkunov <[email protected]>
(cherry picked from commit 9b66bb0)
mergify bot pushed a commit that referenced this pull request Dec 12, 2024
* Update logging.reference.yml.tmpl
* Run `make update` to regenerate the docs

---------

Co-authored-by: Denis Rechkunov <[email protected]>
(cherry picked from commit 9b66bb0)
mergify bot pushed a commit that referenced this pull request Dec 12, 2024
* Update logging.reference.yml.tmpl
* Run `make update` to regenerate the docs

---------

Co-authored-by: Denis Rechkunov <[email protected]>
(cherry picked from commit 9b66bb0)
rdner pushed a commit that referenced this pull request Dec 13, 2024
* Update logging.reference.yml.tmpl
* Run `make update` to regenerate the docs

---------

Co-authored-by: Denis Rechkunov <[email protected]>
(cherry picked from commit 9b66bb0)

Co-authored-by: Agent Fitz ;-) <[email protected]>
rdner pushed a commit that referenced this pull request Dec 13, 2024
* Update logging.reference.yml.tmpl
* Run `make update` to regenerate the docs

---------

Co-authored-by: Denis Rechkunov <[email protected]>
(cherry picked from commit 9b66bb0)

Co-authored-by: Agent Fitz ;-) <[email protected]>
@rdner rdner added the forwardport-main Automated forwardport with mergify label Dec 13, 2024
mergify bot pushed a commit that referenced this pull request Dec 13, 2024
* Update logging.reference.yml.tmpl
* Run `make update` to regenerate the docs

---------

Co-authored-by: Denis Rechkunov <[email protected]>
(cherry picked from commit 9b66bb0)

# Conflicts:
#	x-pack/functionbeat/functionbeat.reference.yml
rdner added a commit that referenced this pull request Dec 13, 2024
* Update logging.reference.yml.tmpl
* Run `make update` to regenerate the docs

---------

Co-authored-by: Denis Rechkunov <[email protected]>
(cherry picked from commit 9b66bb0)

Co-authored-by: Agent Fitz ;-) <[email protected]>
Co-authored-by: Denis <[email protected]>
rdner added a commit that referenced this pull request Jan 10, 2025
…42035)

* Correct the default filename of events-data (#41808)

* Update logging.reference.yml.tmpl
* Run `make update` to regenerate the docs

---------

Co-authored-by: Denis Rechkunov <[email protected]>
(cherry picked from commit 9b66bb0)

# Conflicts:
#	x-pack/functionbeat/functionbeat.reference.yml

* Delete x-pack/functionbeat/functionbeat.reference.yml

---------

Co-authored-by: Agent Fitz ;-) <[email protected]>
Co-authored-by: Denis <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-8.x Automated backport to the 8.x branch with mergify backport-8.15 Automated backport to the 8.15 branch with mergify backport-8.16 Automated backport with mergify backport-8.17 Automated backport with mergify forwardport-main Automated forwardport with mergify Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants