-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Correct the default filename of events-data #41808
Conversation
💚 CLA has been signed |
Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane) |
Thanks @f1tz for your contribution. |
Thanks, I have already signed the CLA. |
@f1tz thank you for your contribution! https://github.com/search?q=repo%3Aelastic%2Fbeats+-event-data&type=code It would be nice to do that in one go, so all the docs are in sync. Thanks! @belimawr as you worked on #38767, I think it might be a typo in the filename actually, not in the docs because all the config parameters have What do you think we should fix here? |
Yes, indeed it's a typo in the docs. I believe the only other file that needs updating is libbeat/_meta/config/logging.reference.yml.tmpl, the other configuration files are generated from it. |
@belimawr could you please open an issue with this detail so it can get addressed (fyi @kilfoyle ) |
@nimarezainia I believe this feature only documented here and in the Elastic-Agent standalone logging, so I just created the PR to fix it: elastic/ingest-docs#1520 |
thank you much appreciated, |
@f1tz could you please update
make update in the root of the repository.
This should update all the occurrences of this typo. Thanks! |
/test |
* Update logging.reference.yml.tmpl * Run `make update` to regenerate the docs --------- Co-authored-by: Denis Rechkunov <[email protected]> (cherry picked from commit 9b66bb0)
* Update logging.reference.yml.tmpl * Run `make update` to regenerate the docs --------- Co-authored-by: Denis Rechkunov <[email protected]> (cherry picked from commit 9b66bb0)
* Update logging.reference.yml.tmpl * Run `make update` to regenerate the docs --------- Co-authored-by: Denis Rechkunov <[email protected]> (cherry picked from commit 9b66bb0)
* Update logging.reference.yml.tmpl * Run `make update` to regenerate the docs --------- Co-authored-by: Denis Rechkunov <[email protected]> (cherry picked from commit 9b66bb0) Co-authored-by: Agent Fitz ;-) <[email protected]>
* Update logging.reference.yml.tmpl * Run `make update` to regenerate the docs --------- Co-authored-by: Denis Rechkunov <[email protected]> (cherry picked from commit 9b66bb0) Co-authored-by: Agent Fitz ;-) <[email protected]>
* Update logging.reference.yml.tmpl * Run `make update` to regenerate the docs --------- Co-authored-by: Denis Rechkunov <[email protected]> (cherry picked from commit 9b66bb0) # Conflicts: # x-pack/functionbeat/functionbeat.reference.yml
* Update logging.reference.yml.tmpl * Run `make update` to regenerate the docs --------- Co-authored-by: Denis Rechkunov <[email protected]> (cherry picked from commit 9b66bb0) Co-authored-by: Agent Fitz ;-) <[email protected]> Co-authored-by: Denis <[email protected]>
…42035) * Correct the default filename of events-data (#41808) * Update logging.reference.yml.tmpl * Run `make update` to regenerate the docs --------- Co-authored-by: Denis Rechkunov <[email protected]> (cherry picked from commit 9b66bb0) # Conflicts: # x-pack/functionbeat/functionbeat.reference.yml * Delete x-pack/functionbeat/functionbeat.reference.yml --------- Co-authored-by: Agent Fitz ;-) <[email protected]> Co-authored-by: Denis <[email protected]>
Change 'event-data' to 'events-data' in the document.
Reference:
beats/libbeat/tests/system/beat/beat.py
Line 535 in 1bd39c5
beats/libbeat/tests/integration/framework.go
Line 626 in 1bd39c5