Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.x](backport #41822) [xpack][metricbeats][gcp] don't skip first value in histogram calculations #41870

Merged
merged 2 commits into from
Dec 23, 2024

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Dec 3, 2024

Proposed commit message

Don't skip first value in histogram upper bound calculations.

This should be done because according to GCP doc (https://cloud.google.com/monitoring/api/ref_v3/rpc/google.api) the histogram (Exponential and Linear) upper bound should include bucket values at index 0.
Screenshot 2024-11-28 at 3 18 09 PM
Screenshot 2024-11-28 at 3 18 47 PM

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Disruptive User Impact

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Closes #

Use cases

Screenshots

Here is screenshot from local test - values seem to be ok
Screenshot 2024-11-28 at 1 28 11 PM

Logs


This is an automatic backport of pull request #41822 done by [Mergify](https://mergify.com).

…tions (#41822)

* [xpack][metricbeats][gcp] don't skip first value in histogram calculations

* update changelog

* update PR id in changelog

* update data_topic.json

* update data_topic.json

* fix integer overflow

---------

Co-authored-by: Ishleen Kaur <[email protected]>
(cherry picked from commit a1acad5)
@mergify mergify bot added the backport label Dec 3, 2024
@mergify mergify bot requested review from a team as code owners December 3, 2024 18:29
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Dec 3, 2024
@botelastic
Copy link

botelastic bot commented Dec 3, 2024

This pull request doesn't have a Team:<team> label.

Copy link
Contributor Author

mergify bot commented Dec 23, 2024

This pull request is now in conflicts. Could you fix it? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b mergify/bp/8.x/pr-41822 upstream/mergify/bp/8.x/pr-41822
git merge upstream/8.x
git push upstream mergify/bp/8.x/pr-41822

@shmsr
Copy link
Member

shmsr commented Dec 23, 2024

@gpop63 / @stefans-elastic is it not needed in 8.x branch??

@stefans-elastic
Copy link
Contributor

@gpop63 / @stefans-elastic is it not needed in 8.x branch??

my bad, let me fix and merge this PR

@stefans-elastic stefans-elastic merged commit d1b356e into 8.x Dec 23, 2024
22 checks passed
@stefans-elastic stefans-elastic deleted the mergify/bp/8.x/pr-41822 branch December 23, 2024 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport needs_team Indicates that the issue/PR needs a Team:* label
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants