Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[7.17](backport #42183) libbeat/tests/system: bump python libs to fix issues with Python 3.13 #42194

Closed
wants to merge 2 commits into from

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Jan 2, 2025

Proposed commit message

This commit fixes errors when installing libbeat python dependencies when running on Python 3.13. This was causing failures when running make update since the python deps installation is part of it.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

How to test this PR locally

# Delete your existing python env
$ python -m venv ./build/python-env --clear
# Since venv is a python module, you need to be running python 3.13 (released Oct 7) in your system
$ python -V
Python 3.13.1
# Create a new python env on 3.13
$ python -m venv ./build/python-env
$ make update

Related issues

…#42183)

(cherry picked from commit b781320)

# Conflicts:
#	libbeat/tests/system/requirements.txt
@mergify mergify bot added backport conflicts There is a conflict in the backported pull request labels Jan 2, 2025
@mergify mergify bot requested a review from a team as a code owner January 2, 2025 15:52
@mergify mergify bot requested review from faec and VihasMakwana and removed request for a team January 2, 2025 15:52
Copy link
Contributor Author

mergify bot commented Jan 2, 2025

Cherry-pick of b781320 has failed:

On branch mergify/bp/7.17/pr-42183
Your branch is up to date with 'origin/7.17'.

You are currently cherry-picking commit b7813206f.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   libbeat/tests/system/requirements.txt

no changes added to commit (use "git add" and/or "git commit -a")

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Jan 2, 2025
@mauri870 mauri870 requested review from mauri870 and removed request for faec and VihasMakwana January 2, 2025 16:59
@mauri870 mauri870 added Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team and removed needs_team Indicates that the issue/PR needs a Team:* label labels Jan 2, 2025
@elasticmachine
Copy link
Collaborator

Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane)

@mauri870
Copy link
Member

mauri870 commented Jan 2, 2025

I believe this change is not needed for 7.17. The main problem was the pinned version of cffi and grpcio, but we don't have these defined in the requirements.txt. Closing as not planned.

@mauri870 mauri870 closed this Jan 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport conflicts There is a conflict in the backported pull request Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants