-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[8.x](backport #42199) Fix Otel API change and update system test golden files to 2025 #42203
Conversation
* Fix Otel API change * Update test files with new date/year (cherry picked from commit 1430cfd) # Conflicts: # x-pack/filebeat/fbreceiver/receiver_test.go
Cherry-pick of 1430cfd has failed:
To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally |
This pull request doesn't have a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some tests are failing due to the CreateLogs
call. The 8.x branch is still in an old otel version that uses CreateLogsReceiver
instead. I suggest we wait for this backport to be merged #42193, then you can remove the benchmark code from this change and only submit the changes in the test files.
We should be good to go merging this one and then #42193 afterward. |
Proposed commit message
Fix Otel API change and update system test golden files to 2025
Checklist
I have commented my code, particularly in hard-to-understand areasI have made corresponding changes to the documentationI have made corresponding change to the default configuration filesI have added tests that prove my fix is effective or that my feature worksI have added an entry inCHANGELOG.next.asciidoc
orCHANGELOG-developer.next.asciidoc
.## Disruptive User Impact## Author's ChecklistHow to test this PR locally
For the OTel change
For the system tests:
## Related issues## Use cases## Screenshots## LogsThis is an automatic backport of pull request #42199 done by [Mergify](https://mergify.com).