-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
x-pack/metricbeat/module/sql: Add debug queries when merge_results: true
#42271
Conversation
This pull request does not have a backport label.
To fixup this pull request, you need to add the backport labels for the needed
|
|
If the actual query is what is considered here, don't you think that this would increase the size of the document significantly? Some of the queries can be long. |
Yes. If you see the related issue's description, Lalit noted the same that the query field was left out because it could take up space in cases of multiple long queries. We're adding this feature now since the current behavior doesn't match when A sample PR: elastic/integrations#12216 demonstrates this approach in integrations. While the query field preservation is optional, users who need it for debugging or analysis purposes can easily enable it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
…true` (#42271) (#42285) (cherry picked from commit d288e54) Co-authored-by: subham sarkar <[email protected]>
Proposed commit message
Add debug queries when
merge_results: true
. No new configuration added to match the behaviour whenmerge_results: false
. Previously, as it was multiple queries that results in merge of results, the query parameter was left entry and hence the field was omitted out whenmerge_results: true
. Now, we will publish it from here. Users that want this can keep it and others who do not want it can drop it.Checklist
CHANGELOG.next.asciidoc
orCHANGELOG-developer.next.asciidoc
.How to test this PR locally
merge_results
is set totrue
.Related issues
transaction_logs
data stream for debug purposes integrations#12216performance
data stream for debugging purposes integrations#12212Screenshots
merge_results: false
:merge_results: true
: