Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.x](backport #42304) Allow use of version qualifier for staging artifacts #42319

Merged
merged 1 commit into from
Jan 16, 2025

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Jan 16, 2025

Proposed commit message

This commits adds support for an optional $VERSION_QUALIFIER env var/build option in the packaging pipeline to allow building prerelease artifacts from staging.

How to test this PR locally

Tested a staging build using this PR with VERSION_QUALIFIER="alpha1" (also passed DRA_BRANCH="main" as this PR is based on main and we'd normally have tested alpha1 on main until 9.0 is cut): https://buildkite.com/elastic/beats-packaging-pipeline/builds/2138#01946b34-0e11-40b0-9610-cc647d2bea1e

Also tested a snapshot build (using DRA_BRANCH="main" and RUN_SNAPSHOT="true") to ensure that an empty --qualifier option works as advertised by the release manager: https://buildkite.com/elastic/beats-packaging-pipeline/builds/2143

Related issues

https://github.com/elastic/ingest-dev/issues/4857


This is an automatic backport of pull request #42304 done by [Mergify](https://mergify.com).

This commits adds support for an optional $VERSION_QUALIFIER env var/build option in the packaging pipeline to allow building prerelease artifacts from staging.

Closes https://github.com/elastic/ingest-dev/issues/4857

(cherry picked from commit c7b6ad8)
@mergify mergify bot added the backport label Jan 16, 2025
@mergify mergify bot requested a review from a team as a code owner January 16, 2025 07:35
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Jan 16, 2025
@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Jan 16, 2025
Copy link
Collaborator

@jlind23 jlind23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but weird that you kept a TODO in it.

@dliappis
Copy link
Contributor

dliappis commented Jan 16, 2025

LGTM but weird that you kept a TODO in it.

The todos will be removed in main in the near future and we keep them as is here eases backports

@dliappis dliappis merged commit b2d6738 into 8.x Jan 16, 2025
148 checks passed
@dliappis dliappis deleted the mergify/bp/8.x/pr-42304 branch January 16, 2025 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants