Move libbeat filebeat dependency to libbeat #4465
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ruflin
force-pushed
the
filebeat-dependency
branch
from
8ca0613 to
564a3f4
Compare
Libbeat had a dependency on filebeat because of file rotation. This PR removes the dependency by moving the file rotation code to
ruflin
force-pushed
the
filebeat-dependency
branch
from
564a3f4 to
9bda57d
Compare
|
Failure is not related to this change. It seems like the old race condition hunting me is back: #4314 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Libbeat had a dependency on filebeat because of file rotation. This PR removes the dependency by moving the file rotation code to