Filebeat modules: Machine learning jobs #4506
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tsg
added
Filebeat
|
I pushed everything, but I expect the test to be failing until the Kibana snapshots are fixed (there's an issue with the current ones). But should be otherwise ready for reviews. |
|
Also, I'm leaving docs for later, since this will mainly mean document the |
exekias
reviewed
Jun 22, 2017
filebeat/beater/filebeat.go
Outdated
| @@ -66,8 +67,14 @@ func New(b *beat.Beat, rawConfig *common.Config) (beat.Beater, error) { | |||
| } | |||
| } | |||
|
|
|||
| // In the setup command, | |||
tsg
force-pushed
the
machine_learning_jobs
branch
2 times, most recently
from
0b9286e to
3c04b7f
Compare
This adds support for loading ML configurations (job + datafeed) from the filebeat modules. An example ML configuration is added to the Nginx Filebeat module. This sample applies ML anomaly detection on the response codes. The loading is implemented as part of the `setup` command and part of the `--setup` flag. If a job configuration with the same ID exists, it is not overwritten, because deleting jobs could potentially delete user data. The user should manually delete the jobs in the UI if they want to upgrade.
tsg
force-pushed
the
machine_learning_jobs
branch
from
3c04b7f to
68641f6
Compare
|
Squashed and rebased. Remaining test failures seem unrelated, but I'm hoping for some more green on this run. |
tsg
added
needs_backport
|
💯 tested by hand, it adds the job both with |
ruflin
reviewed
Jun 27, 2017
| @@ -0,0 +1,44 @@ | |||
| { | |||
| "job_id": "JOB_ID", | |||
There was a problem hiding this comment.
Only skimmed through the PR but this kind of looked fishy?
There was a problem hiding this comment.
Yeah, it gets replaced in code with a generated job id. Didn't know how to reflect this otherwise.
There was a problem hiding this comment.
To clarify, I don't mean a textual replacement. The json gets decoded and the key replaced.
5 tasks
tsg
added a commit
to tsg/beats
that referenced
this pull request
Jun 30, 2017
This adds support for loading ML configurations (job + datafeed) from the filebeat modules. An example ML configuration is added to the Nginx Filebeat module. This sample applies ML anomaly detection on the response codes. The loading is implemented as part of the `setup` command and part of the `--setup` flag. If a job configuration with the same ID exists, it is not overwritten, because deleting jobs could potentially delete user data. The user should manually delete the jobs in the UI if they want to upgrade. (cherry picked from commit 1213483)
monicasarbu
pushed a commit
that referenced
this pull request
Jul 3, 2017
) * Filebeat modules: Machine Learning jobs (#4506) This adds support for loading ML configurations (job + datafeed) from the filebeat modules. An example ML configuration is added to the Nginx Filebeat module. This sample applies ML anomaly detection on the response codes. The loading is implemented as part of the `setup` command and part of the `--setup` flag. If a job configuration with the same ID exists, it is not overwritten, because deleting jobs could potentially delete user data. The user should manually delete the jobs in the UI if they want to upgrade. (cherry picked from commit 1213483) * use 5.5 snapshots for now * Adjusted test for 5.x * Another test adjustments * On a 400 response on _xpack, assume that Xpack is not installed * Another test fix
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for loading ML configurations (job + datafeed) from the filebeat modules. An example ML configuration is added to the Nginx Filebeat module. This sample applies ML anomaly detection on the response codes.
The loading is implemented as part of the
setupcommand and part of the--setupflag.If a job configuration with the same ID exists, it is not overwritten, because deleting jobs could potentially delete user data. The user should manually delete the jobs in the UI if they want to upgrade.
ToDOs for the overall implementation:
snaphost.yml)