Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix monitor.name being empty by default #4856

Merged
merged 2 commits into from
Aug 9, 2017
Merged

Fix monitor.name being empty by default #4856

merged 2 commits into from
Aug 9, 2017

Conversation

urso
Copy link

@urso urso commented Aug 9, 2017 •
edited
Loading

Resolve #4852

  • Fixes the monitor.name field default to monitor.type if not configured
  • Update HTTP dashboards to filter on monitor.type, which will always be http for all HTTP related monitors.

@urso urso added bug Heartbeat in progress Pull request is currently in progress. needs_backport PR is waiting to be backported to other branches. labels Aug 9, 2017
@urso urso force-pushed the fix/heartbeat-monitor-name branch from 7ed2f0c to 481abe1 Compare August 9, 2017 13:49
@urso urso changed the title [WIP] Fix monitor.name being empty by default Fix monitor.name being empty by default Aug 9, 2017
@urso urso added review and removed in progress Pull request is currently in progress. labels Aug 9, 2017
@monicasarbu
Copy link
Contributor

@urso Great, waiting for green.

@andrewkroh andrewkroh merged commit a1031e8 into elastic:master Aug 9, 2017
urso pushed a commit to urso/beats that referenced this pull request Aug 11, 2017
Fix monitor.name being empty by default (elastic#4856)
aea3045 
* Fix monitor.name being empty by default

* Update dashboards to filter by monitor.type

(cherry picked from commit a1031e8)
@urso urso mentioned this pull request Aug 11, 2017
Merged
@urso urso removed the needs_backport PR is waiting to be backported to other branches. label Aug 11, 2017
tsg pushed a commit that referenced this pull request Aug 14, 2017
@tsg
Fix monitor.name being empty by default (#4856) (#4877)
e341da3 
* Fix monitor.name being empty by default
* Update dashboards to filter by monitor.type

(cherry picked from commit a1031e8)
@urso urso deleted the fix/heartbeat-monitor-name branch February 19, 2019 18:29
leweafan pushed a commit to leweafan/beats that referenced this pull request Apr 28, 2023
@tsg
Fix monitor.name being empty by default (elastic#4856) (elastic#4877)
cb2ed28 
* Fix monitor.name being empty by default
* Update dashboards to filter by monitor.type

(cherry picked from commit 97b115d)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@monicasarbu monicasarbu monicasarbu approved these changes

Assignees
No one assigned
Labels
bug Heartbeat review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@urso @monicasarbu @andrewkroh