Add system uptime metricset #4887
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewkroh
force-pushed
the
feature/mb/system-uptime
branch
from
06caa22 to
4ddf98c
Compare
This adds a new metricset that reports the system uptime. The metricset is enabled by default with a period of 15m. The metricset reports one field `system.uptime.duration.ms` that is the system's uptime reported in milliseconds. In Kibana the field is formatted as a `duration` and shown in human-readable format (e.g. "8 days"). Closes elastic#4848
andrewkroh
force-pushed
the
feature/mb/system-uptime
branch
from
4ddf98c to
5e514dc
Compare
exekias
approved these changes
Aug 14, 2017
metricbeat/modules.d/system.yml
Outdated
|
|
||
| - module: system | ||
| period: 15m | ||
| metricsets: [uptime] |
There was a problem hiding this comment.
I'm wondering if this format (instead of a list with -) may confuse some users, as we don't follow the same pattern in the whole file. WDYT?
There was a problem hiding this comment.
I agree. Changed to block style.
ruflin
approved these changes
Aug 14, 2017
| @@ -79,6 +79,11 @@ def field_to_json(fields, desc, path, output, | |||
| if "format" in desc: | |||
| fieldFormat["id"] = desc["format"] | |||
|
|
|||
| if "input_format" in desc: | |||
CHANGELOG.asciidoc
Outdated
| @@ -83,6 +83,8 @@ https://github.com/elastic/beats/compare/v6.0.0-beta1...master[Check the HEAD di | |||
| - Add http server metricset to support push metrics via http. {pull}4770[4770] | |||
| - Make config object public for graphite and http server {pull}4820[4820] | |||
|
|
|||
| - Add system uptime metricset. {issue}[4848[4848] | |||
There was a problem hiding this comment.
Empty line above on purpose?
jsoriano
reviewed
Dec 5, 2018
| @@ -0,0 +1,28 @@ | |||
| // +build darwin linux openbsd windows | |||
There was a problem hiding this comment.
@andrewkroh was there any reason to exclude freebsd here? sigar has the implementation for this. // cc @kaiyan-sheng @ruflin
There was a problem hiding this comment.
I can’t think of any reason. It probably should be tagged as freebsd,cgo.
There was a problem hiding this comment.
Hi, what is the difference between freebsd & freebsd,cgo tags?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a new metricset that reports the system uptime. The metricset
is enabled by default with a period of 15m.
The metricset reports one field
system.uptime.duration.msthat is the system'suptime reported in milliseconds. In Kibana the field is formatted as a
durationand shown in human-readable format (e.g. "8 days").
Closes #4848