Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update and reorganize system module config docs #4909

Merged
merged 1 commit into from
Aug 16, 2017

Conversation

andrewkroh
Copy link
Member

@andrewkroh andrewkroh commented Aug 15, 2017

Move configuration options from module page to their respective metricset pages.

  • Add process.include_cpu_ticks to reference config file (it was missing).
  • Rename Darwin to macOS in list of supported operating systems.
  • Add docs for core.metrics and cpu.metrics.

Needs backport to 6.0 branch.

Move configuration options from module page to their respective metricset pages.

- Add `process.include_cpu_ticks` to reference config file (it was missing).
- Rename Darwin to macOS in list of supported operating systems.
- Add docs for `core.metrics` and `cpu.metrics`.
@andrewkroh andrewkroh added docs Metricbeat Metricbeat needs_backport PR is waiting to be backported to other branches. review labels Aug 15, 2017
@andrewkroh andrewkroh requested a review from dedemorton August 15, 2017 22:26
@andrewkroh andrewkroh mentioned this pull request Aug 15, 2017
42 tasks
@dedemorton
Copy link
Contributor

There are a couple of other metricsets (filesystem and fsstat) where this statement might be needed:

Configuration
There are no configuration options for this metricset.

Otherwise, LGTM.

@andrewkroh
Copy link
Member Author

@dedemorton Good eye, but actually I omitted this from filesystem and fsstats to avoid conflicts with #4906 which adds the "Configuration" section for those two metricsets. After that one merges we will be consistent.

@tsg tsg merged commit 1495b3a into elastic:master Aug 16, 2017
@andrewkroh andrewkroh removed the needs_backport PR is waiting to be backported to other branches. label Aug 16, 2017
andrewkroh added a commit to andrewkroh/beats that referenced this pull request Aug 16, 2017
Move configuration options from module page to their respective metricset pages.

- Add `process.include_cpu_ticks` to reference config file (it was missing).
- Rename Darwin to macOS in list of supported operating systems.
- Add docs for `core.metrics` and `cpu.metrics`.
(cherry picked from commit 1495b3a)
tsg pushed a commit that referenced this pull request Aug 18, 2017
Move configuration options from module page to their respective metricset pages.

- Add `process.include_cpu_ticks` to reference config file (it was missing).
- Rename Darwin to macOS in list of supported operating systems.
- Add docs for `core.metrics` and `cpu.metrics`.
(cherry picked from commit 1495b3a)
@andrewkroh andrewkroh deleted the feature/system-module-docs branch December 14, 2017 21:28
leweafan pushed a commit to leweafan/beats that referenced this pull request Apr 28, 2023
…ic#4917)

Move configuration options from module page to their respective metricset pages.

- Add `process.include_cpu_ticks` to reference config file (it was missing).
- Rename Darwin to macOS in list of supported operating systems.
- Add docs for `core.metrics` and `cpu.metrics`.
(cherry picked from commit d75a496)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants