Cherry-pick #4972 to 6.0: Add option to enable/disable LS output slow start #5003
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add option to enable/disable LS output slow start - add support to disable slow start in LS output - disable slow start by default. LS with java rewrite returns some kind of heartbeat every few seconds, so beats can tell the batch is still actively processed. With this change in LS, the original purpose of limiting batch sizes has become somewhat superfluous and is not really required anymore. -> We disable slow start and windowing by default, but keep the setting in case we find it's still required (e.g. when sending to older LS instances). * Update docs and reference configs * Remove unused method * Update changelog * review (cherry picked from commit c2360d0)
leweafan
pushed a commit
to leweafan/beats
that referenced
this pull request
Apr 28, 2023
…stic#5003) * Add option to enable/disable LS output slow start - add support to disable slow start in LS output - disable slow start by default. LS with java rewrite returns some kind of heartbeat every few seconds, so beats can tell the batch is still actively processed. With this change in LS, the original purpose of limiting batch sizes has become somewhat superfluous and is not really required anymore. -> We disable slow start and windowing by default, but keep the setting in case we find it's still required (e.g. when sending to older LS instances). * Update docs and reference configs * Remove unused method * Update changelog * review (cherry picked from commit ffa2e64)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick of PR #4972 to 6.0 branch. Original message:
LS with java rewrite returns some kind of heartbeat every few seconds,
so beats can tell the batch is still actively processed. With this
change in LS, the original purpose of limiting batch sizes has become somewhat
superfluous and is not really required anymore.
-> We disable slow start and windowing by default, but keep the setting
in case we find it's still required (e.g. when sending to older LS
instances).