Make python tests not executables #5449
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Turns out that if a `test_*.py` file is executable, nosetests doesn't pick it up, so the tests are not executed on Linux/Mac. This was the case with two files in Filebeat. This adds a `make check` check to look for such files, so this doesn't happen in the future.
tsg
added
needs_backport
|
I opened this separately from #5443 so we can backport it immediately to the 6.0 branch. |
andrewkroh
approved these changes
Oct 26, 2017
|
|
|
man find (on Linux)
These work on Linux but not on macOS. hmm
|
andrewkroh
approved these changes
Oct 27, 2017
|
|
|
That test seems stable on my computer, so I'm pretty clueless on why it might fail on Travis only. |
|
No, I spoke to soon. The test is flaky and I could get it to fail on my laptop when running it in a loop. |
|
I opened #5458 for the flaky test. |
urso
approved these changes
Oct 27, 2017
|
I skipped the flaky test, we have #5458 to track that. |
|
jenkins, test it |
ruflin
pushed a commit
to ruflin/beats
that referenced
this pull request
Nov 28, 2017
* Make python tests not executables Turns out that if a `test_*.py` file is executable, nosetests doesn't pick it up, so the tests are not executed on Linux/Mac. This was the case with two files in Filebeat. This adds a `make check` check to look for such files, so this doesn't happen in the future. (cherry picked from commit b8b7f8a)
ruflin
removed
the
needs_backport
exekias
pushed a commit
that referenced
this pull request
Nov 28, 2017
* Make python tests not executables Turns out that if a `test_*.py` file is executable, nosetests doesn't pick it up, so the tests are not executed on Linux/Mac. This was the case with two files in Filebeat. This adds a `make check` check to look for such files, so this doesn't happen in the future. (cherry picked from commit b8b7f8a)
leweafan
pushed a commit
to leweafan/beats
that referenced
this pull request
Apr 28, 2023
* Make python tests not executables Turns out that if a `test_*.py` file is executable, nosetests doesn't pick it up, so the tests are not executed on Linux/Mac. This was the case with two files in Filebeat. This adds a `make check` check to look for such files, so this doesn't happen in the future. (cherry picked from commit baa09e8)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Turns out that if a
test_*.pyfile is executable, nosetestsdoesn't pick it up, so the tests are not executed on Linux/Mac.
This was the case with two files in Filebeat.
This adds a
make checkcheck to look for such files, so thisdoesn't happen in the future.