Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Go vet complains on composite literal uses unkeyed fields #5690

Closed
wants to merge 1 commit into from

Conversation

ph
Copy link
Contributor

@ph ph commented Nov 22, 2017

This was found with #5687, this problems does not seems to be triggered on the CI, only on my local environment when I run make check, I am running go 1.9.2, I will do a bit more check on the CI to see why this is not triggered.

Checking file template/config.go
Checking file template/load.go
Checking file template/processor.go
Checking file template/template.go
Checking file template/processor_test.go
template/processor_test.go:141: github.com/elastic/beats/libbeat/common.DynamicType composite literal uses unkeyed fields
template/processor_test.go:147: github.com/elastic/beats/libbeat/common.DynamicType composite literal uses unkeyed fields
template/processor_test.go:153: github.com/elastic/beats/libbeat/common.DynamicType composite literal uses unkeyed fields
Checking file template/template_test.go
exit status 1

 ```
Checking file template/config.go
Checking file template/load.go
Checking file template/processor.go
Checking file template/template.go
Checking file template/processor_test.go
template/processor_test.go:141: github.com/elastic/beats/libbeat/common.DynamicType composite literal uses unkeyed fields
template/processor_test.go:147: github.com/elastic/beats/libbeat/common.DynamicType composite literal uses unkeyed fields
template/processor_test.go:153: github.com/elastic/beats/libbeat/common.DynamicType composite literal uses unkeyed fields
Checking file template/template_test.go
exit status 1
```
@ph ph added the review label Nov 22, 2017
@ph ph closed this Nov 22, 2017
@ph ph removed the review label Nov 22, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant