Fix filesystem used percentage #6231
Merged
+2
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewkroh
added
bug
review
help wanted
andrewkroh
force-pushed
the
bugfix/mb/sys-filesystem-used-pct
branch
from
346d3b0 to
83df7c2
Compare
|
@andrewkroh What does the adopt-me label mean here? Should we backport this fix? |
andrewkroh
added
Metricbeat
|
Accidentally added that label. Let's do some real world testing before back-porting it. I want to get some feedback from the users that reported the issue. |
andrewkroh
force-pushed
the
bugfix/mb/sys-filesystem-used-pct
branch
from
83df7c2 to
e9be3fb
Compare
|
@andrewkroh Sorry, needs a rebase. Changelog fun :-( |
The used percentage reported by Metricbeat does not match what is reported by `df`. Metricbeat's computation of the `system.filesystem.used.pct` value was based on the total number of bytes, but df uses the total number of bytes available to the unprivileged user. | FS | Blocks | Used | Available | Use % | Mount | Metricbeat Used % After This Change | Before This Change | |----------|-------------|-------------|------------|-------|-------|-------------------------------------|--------------------| | /dev/vda | 21137846272 | 16992858112 | 3071246336 | 85 | / | 0.846928312 | 0.8039067885 | Fixes elastic#5494
andrewkroh
force-pushed
the
bugfix/mb/sys-filesystem-used-pct
branch
from
e9be3fb to
51c7249
Compare
|
Rebased to fix conflict. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The used percentage reported by Metricbeat does not match what is reported by
df. Metricbeat's computation of thesystem.filesystem.used.pctvalue was based on the total number of bytes, but df uses the total number of bytes available to the unprivileged user.Fixes #5494