Reduce default pipelining to Logstash to a more tame '2'. #6250
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s memory pressure on LS. We do have improvements to reduce memory usage in LS here logstash-plugins/logstash-input-beats#286 However, I think it makes sense to start with this fix here, and ramp up this number on the next major when we have more confidence that 5 is the magic number. At the end of the day, magic numbers are always problematic, but 5 can cause quite a bit of pressure when there's a high ratio of Beats:Logstash instances
|
I am +1 with that change @urso and myself already talk about it, we have a
sync tomorrow i will bring it up and merge it.
On Wed, Jan 31, 2018 at 9:13 PM Andrew Cholakian ***@***.***> wrote:
This reduces memory pressure on LS.
We do have improvements to reduce memory usage in LS here
logstash-plugins/logstash-input-beats#286
<logstash-plugins/logstash-input-beats#286>
However, I think it makes sense to start with this fix here, and ramp up
this number on the next major when we have more confidence that 5 is the
magic number.
At the end of the day, magic numbers are always problematic, but 5 can
cause quite a bit of pressure when there's a high ratio of Beats:Logstash
instances. I think that two is a good compromise.
------------------------------
You can view, comment on, or merge this pull request online at:
#6250
Commit Summary
- Reduce default pipelining to Logstash to a more tame '2'. This
reduces memory pressure on LS.
File Changes
- *M* auditbeat/auditbeat.reference.yml
<https://github.com/elastic/beats/pull/6250/files#diff-0> (2)
- *M* filebeat/filebeat.reference.yml
<https://github.com/elastic/beats/pull/6250/files#diff-1> (2)
- *M* heartbeat/heartbeat.reference.yml
<https://github.com/elastic/beats/pull/6250/files#diff-2> (2)
- *M* libbeat/_meta/config.reference.yml
<https://github.com/elastic/beats/pull/6250/files#diff-3> (2)
- *M* libbeat/outputs/logstash/config.go
<https://github.com/elastic/beats/pull/6250/files#diff-4> (2)
- *M* metricbeat/metricbeat.reference.yml
<https://github.com/elastic/beats/pull/6250/files#diff-5> (2)
- *M* packetbeat/packetbeat.reference.yml
<https://github.com/elastic/beats/pull/6250/files#diff-6> (2)
- *M* winlogbeat/winlogbeat.reference.yml
<https://github.com/elastic/beats/pull/6250/files#diff-7> (2)
Patch Links:
- https://github.com/elastic/beats/pull/6250.patch
- https://github.com/elastic/beats/pull/6250.diff
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#6250>, or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAACgN0q29bQ6Kp_0p6jNFrvDIrPffOLks5tQR23gaJpZM4R08td>
.
--
ph
|
urso
approved these changes
Feb 1, 2018
|
Docs update and changelog are missing, but I'll follow up in a new PR. |
tsg
added
needs_backport
tsg
pushed a commit
to tsg/beats
that referenced
this pull request
Feb 1, 2018
…s memory pressure on LS. (elastic#6250) We do have improvements to reduce memory usage in LS here logstash-plugins/logstash-input-beats#286 However, I think it makes sense to start with this fix here, and ramp up this number on the next major when we have more confidence that 5 is the magic number. At the end of the day, magic numbers are always problematic, but 5 can cause quite a bit of pressure when there's a high ratio of Beats:Logstash instances (cherry picked from commit d3a0b94)
tsg
added a commit
to tsg/beats
that referenced
this pull request
Feb 1, 2018
Follow up for elastic#6250.
urso
pushed a commit
that referenced
this pull request
Feb 1, 2018
ph
pushed a commit
that referenced
this pull request
Feb 1, 2018
…s memory pressure on LS. (#6250) (#6252) We do have improvements to reduce memory usage in LS here logstash-plugins/logstash-input-beats#286 However, I think it makes sense to start with this fix here, and ramp up this number on the next major when we have more confidence that 5 is the magic number. At the end of the day, magic numbers are always problematic, but 5 can cause quite a bit of pressure when there's a high ratio of Beats:Logstash instances (cherry picked from commit d3a0b94)
tsg
added a commit
to tsg/beats
that referenced
this pull request
Feb 1, 2018
Follow up for elastic#6250. (cherry picked from commit c4b00a9)
ph
pushed a commit
that referenced
this pull request
Feb 2, 2018
leweafan
pushed a commit
to leweafan/beats
that referenced
this pull request
Apr 28, 2023
…s memory pressure on LS. (elastic#6250) (elastic#6252) We do have improvements to reduce memory usage in LS here logstash-plugins/logstash-input-beats#286 However, I think it makes sense to start with this fix here, and ramp up this number on the next major when we have more confidence that 5 is the magic number. At the end of the day, magic numbers are always problematic, but 5 can cause quite a bit of pressure when there's a high ratio of Beats:Logstash instances (cherry picked from commit deb31ca)
leweafan
pushed a commit
to leweafan/beats
that referenced
this pull request
Apr 28, 2023
…for elastic#6250 (elastic#6258) * Add docs update and changelog entry for elastic#6250 (elastic#6253) Follow up for elastic#6250. (cherry picked from commit ebabc49)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reduces memory pressure on LS.
We do have improvements to reduce memory usage in LS here logstash-plugins/logstash-input-beats#286
However, I think it makes sense to start with this fix here, and ramp up this number on the next major when we have more confidence that 5 is the magic number.
At the end of the day, magic numbers are always problematic, but 5 can cause quite a bit of pressure when there's a high ratio of Beats:Logstash instances. I think that two is a good compromise.