-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rabbitmq queue metricset message rates #6606
Changes from 7 commits
ab97cf7
e271a26
87bc235
20453c4
9b9ccf0
c0b0396
62c4420
ed2b770
585d43d
aa37bef
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -121,7 +121,6 @@ https://github.com/elastic/beats/compare/v6.0.0-beta2...master[Check the HEAD di | |
|
||
*Metricbeat* | ||
|
||
- Add connections metricset to RabbitMQ module {pull}6548[6548] | ||
- Change field type of http header from nested to object {pull}5258[5258] | ||
- Fix the fetching of process information when some data is missing under MacOS X. {issue}5337[5337] | ||
- Change `MySQL active connections` visualization title to `MySQL total connections`. {issue}4812[4812] | ||
|
@@ -256,6 +255,8 @@ https://github.com/elastic/beats/compare/v6.0.0-beta2...master[Check the HEAD di | |
- Making the MongoDB module GA. {pull}6554[6554] | ||
- Allow to disable labels `dedot` in Docker module, in favor of a safe way to keep dots. {pull}6490[6490] | ||
- Add experimental module to collect metrics from munin nodes. {pull}6517[6517] | ||
- Add connections metricset to RabbitMQ module {pull}6548[6548] | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Was this line added on purpose? Was it missing in a previews PR? If yes, the PR number seems to be off. |
||
- Add message rates to the RabbitMQ queue metricset {issue}6442[6442] {pull}6606[6606] | ||
|
||
*Packetbeat* | ||
|
||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -171,6 +171,11 @@ func Bool(key string, opts ...schema.SchemaOption) schema.Conv { | |
return schema.SetOptions(schema.Conv{Key: key, Func: toBool}, opts) | ||
} | ||
|
||
// Float creates a Conv object for parsing floats | ||
func Float(key string, opts ...schema.SchemaOption) schema.Conv { | ||
return schema.SetOptions(schema.Conv{Key: key, Func: toInteger}, opts) | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. You use the |
||
} | ||
|
||
func toInteger(key string, data map[string]interface{}) (interface{}, error) { | ||
emptyIface, exists := data[key] | ||
if !exists { | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This line should be removed for this PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure, I can remove it, but currently this line is in the wrong section - Bugfixes, while it should be in Added.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left the line in the change log, let me know if I should revert it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm just realising now that this log line has been moved and not added.
+1 on moving it to the right section.