Use default metricsets in hints based autodiscover #6634
Conversation
|
I've opened #6636 to still support the now unhardcoded Prometheus use case |
| // fallback to all metricsets if module has no defaults | ||
| msets, err = m.Registry.DefaultMetricSets(module) | ||
| if err != nil || len(msets) == 0 { | ||
| msets = m.Registry.MetricSets(module) |
There was a problem hiding this comment.
I worry that with that we enable experimental metricsets which is probably not our intention.
There was a problem hiding this comment.
Could we exclude experimental metricsets from defaults? Is there an alternative way to explicitly enable metricsets from hints?
There was a problem hiding this comment.
Do we agree to set default metricsets for all modules? If that's the case this is not a issue
There was a problem hiding this comment.
yes, we do. but if we merge this we should make sure then that we follow up with the changes until the next release.
There was a problem hiding this comment.
Well, having that this feature is experimental... we could probably live with experimental metricsets being spawned here 😇
| "enabled": true, | ||
| }, | ||
| }, | ||
| // Only module, it should return defaults |
There was a problem hiding this comment.
Instead of a comment here you could add this as message or description to the test and output it when the test fails. This makes hunting down a failing test much easier. We have that already in quite a few other places.
|
Tests and docs updated |
When using hints in Metricbeat, follow this pattern: - If `metricsets` hint is given, use it - If not, use module default metricsets - If no default metricsets, use all module metricsets
exekias
force-pushed
the
unhardcode-prometheus
branch
from
f3de048 to
3bd95df
Compare
When using hints in Metricbeat, follow this pattern:
metricsetshint is given, use it