Extract the Dissect test suite into an external file #7768
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We currently have three implementations of dissect (LS, Ingest and beats), moving the common test case to an external file is the first step to be able to converge to a common specification.
|
LGTM |
|
jenkins test this please |
urso
approved these changes
Jul 30, 2018
|
With the go test suite its common to put input files into a testdata sub-directory. According to
|
According to go help test:
The go tool will ignore a directory named "testdata", making it available
to hold ancillary data needed by the tests.
|
@urso I've moved the fixture into |
ph
added a commit
to ph/beats
that referenced
this pull request
Nov 9, 2018
We currently have three implementations of dissect (LS, Ingest and beats), moving the common test case to an external file is the first step to be able to converge to a common specification. cc @guyboertje @jakelandis (cherry picked from commit 3e85c9a)
ph
added a commit
that referenced
this pull request
Nov 13, 2018
…t a value that can be referenced and add external test suite for dissect (#8861) * Extract the Dissect test suite into an external file (#7768) We currently have three implementations of dissect (LS, Ingest and beats), moving the common test case to an external file is the first step to be able to converge to a common specification. cc @guyboertje @jakelandis (cherry picked from commit 3e85c9a) * Allow to use a star (*) to extract a value that can be referenced. (#8750) This commit adds support for * instead of using a named skip field (?field) this make it compatible with ingest pipeline syntax in 6.5. We are also adding validation enforcing that each indirect field must use an existing and valid reference. Fix: #8054 (cherry picked from commit bb93d05)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We currently have three implementations of dissect (LS, Ingest
and beats), moving the common test case to an external file is the first
step to be able to converge to a common specification.
cc @guyboertje @jakelandis