Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove incorrect mention of HTTP_PROXY in docs #7831

Merged
merged 1 commit into from
Aug 29, 2018

Conversation

urso
Copy link

@urso urso commented Aug 1, 2018

The proxy_url setting in the hearbeat monitors does not fallback to
HTTP_PROXY on purpose. This is, so the configuration/network of outputs
and monitors are kept mostly separate.
This change removes all incorrect mentions of HTTP_PROXY in the
heartbeat monitors documentation and reference config file.

The proxy_url setting in the hearbeat monitors does not fallback to
HTTP_PROXY on purpose. This is, so the configuration/network of outputs
and monitors are kept mostly separate.
This change removes all incorrect mentions of HTTP_PROXY in the
heartbeat monitors documentation and reference config file.
Copy link
Contributor

@dedemorton dedemorton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dedemorton
Copy link
Contributor

@urso I'm assuming this needs to be backported, right? Adding the label...feel free to remove if you don't want this backported.

@dedemorton dedemorton added the needs_backport PR is waiting to be backported to other branches. label Aug 1, 2018
@urso urso merged commit 56b96d8 into elastic:master Aug 29, 2018
urso pushed a commit to urso/beats that referenced this pull request Aug 29, 2018
The proxy_url setting in the hearbeat monitors does not fallback to
HTTP_PROXY on purpose. This is, so the configuration/network of outputs
and monitors are kept mostly separate.
This change removes all incorrect mentions of HTTP_PROXY in the
heartbeat monitors documentation and reference config file.

(cherry picked from commit 56b96d8)
@urso urso added v6.5.0 and removed needs_backport PR is waiting to be backported to other branches. labels Aug 29, 2018
urso pushed a commit to urso/beats that referenced this pull request Aug 29, 2018
The proxy_url setting in the hearbeat monitors does not fallback to
HTTP_PROXY on purpose. This is, so the configuration/network of outputs
and monitors are kept mostly separate.
This change removes all incorrect mentions of HTTP_PROXY in the
heartbeat monitors documentation and reference config file.

(cherry picked from commit 56b96d8)
@urso urso added the v6.4.1 label Aug 29, 2018
urso pushed a commit that referenced this pull request Aug 30, 2018
The proxy_url setting in the hearbeat monitors does not fallback to
HTTP_PROXY on purpose. This is, so the configuration/network of outputs
and monitors are kept mostly separate.
This change removes all incorrect mentions of HTTP_PROXY in the
heartbeat monitors documentation and reference config file.

(cherry picked from commit 56b96d8)
urso pushed a commit that referenced this pull request Aug 30, 2018
The proxy_url setting in the hearbeat monitors does not fallback to
HTTP_PROXY on purpose. This is, so the configuration/network of outputs
and monitors are kept mostly separate.
This change removes all incorrect mentions of HTTP_PROXY in the
heartbeat monitors documentation and reference config file.

(cherry picked from commit 56b96d8)
@urso urso deleted the heartbeat-proxy-url-doc branch February 19, 2019 18:33
leweafan pushed a commit to leweafan/beats that referenced this pull request Apr 28, 2023
…c#8142)

The proxy_url setting in the hearbeat monitors does not fallback to
HTTP_PROXY on purpose. This is, so the configuration/network of outputs
and monitors are kept mostly separate.
This change removes all incorrect mentions of HTTP_PROXY in the
heartbeat monitors documentation and reference config file.

(cherry picked from commit f69da44)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants