[WIP] Add very basic support for x-pack modules in Metricbeat #9230
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In this PR a "fake module" is added for testing. * Import list: This is currently manually maintained to reduce complexity. Should be automated later on. * Docs collection: The metricbeat/scripts/docs_collector.py script needs update to also collect x-pack modules -> see filebeat * Somehow modules.d is not generated yet as expected * Same for the congif files, not generated yet
|
I'd prefer to merge the MSSQL module PR #9202 to get this logic in. But I'd be good if you pulled in the three commits from that PR here and combine it with the
The foo module will need to be removed by the time of the 7.0.0-alpha2 release otherwise it will get released. |
|
Was just temporary to play. Closing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR a "fake module" is added for testing.
This is a subset of #8829 and copied files from Filebeat.