Cherry-pick #9305 to 6.x: Don't generate a config when disabling logs collection with hints #9356
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…astic#9305) When `co.elastic.logs/disable="true"` is used in a container, an incomplete event is generated, what provokes errors about configurations with missing fields. Don't generate configs in these cases. If after that a builder doesn't generate any configuration, it still generates an event but with with an empty list of configs instead of an event without a config field. (cherry picked from commit a4b06ae)
exekias
approved these changes
Dec 3, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick of PR #9305 to 6.x branch. Original message:
When
co.elastic.logs/disable="true"is used in a container, anincomplete event is generated, what provokes errors about configurations
with missing fields. Don't generate configs in these cases.
If a builder doesn't generate any configuration it still generates an event
with an empty list of configs instead of an event without a config field.
Seen in discuss: