Remove the experimental tag from Jolokia autodiscover provider #9706
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsoriano
added
review
libbeat
v7.0.0
Team:Integrations
jsoriano
force-pushed
the
jolokia-autodiscover-ga
branch
from
03c097a to
e04bad3
Compare
ruflin
reviewed
Dec 20, 2018
|
jenkins, test this again please |
ruflin
reviewed
Dec 20, 2018
CHANGELOG.asciidoc
Outdated
| @@ -200,6 +200,12 @@ https://github.com/elastic/beats/compare/v7.0.0-alpha1...v7.0.0-alpha2[Check the | |||
| - Unify dashboard exporter tools. {pull}9097[9097] | |||
| - Add cache.ttl to add_host_metadata. {pull}9359[9359] | |||
| - Add support for index lifecycle management (beta). {pull}7963[7963] | |||
| - Always include Pod UID as part of Pod metadata. {pull]9517[9517] | |||
There was a problem hiding this comment.
Yes, there was something wrong there, fixed.
jsoriano
force-pushed
the
jolokia-autodiscover-ga
branch
from
068caaf to
ced27e7
Compare
ruflin
approved these changes
Dec 21, 2018
|
@jsoriano Should we backport this to 6.x? |
ruflin
approved these changes
Dec 21, 2018
|
@ruflin I was thinking on doing this for 7.0, but I could backport it for 6.7, as you prefer |
|
I assume there are no code changes in this for 6.6 / 6.7 or master? If yes, let's backport. I'm even thinking about updating 6.6? |
|
Ok, I will backport it till 6.6 🙂 |
jsoriano
added
needs_backport
jsoriano
removed
the
needs_backport
jsoriano
added a commit
to jsoriano/beats
that referenced
this pull request
Dec 21, 2018
(cherry picked from commit d286b62)
jsoriano
added a commit
to jsoriano/beats
that referenced
this pull request
Dec 21, 2018
(cherry picked from commit d286b62)
jsoriano
added a commit
that referenced
this pull request
Dec 22, 2018
jsoriano
added a commit
that referenced
this pull request
Dec 22, 2018
leweafan
pushed a commit
to leweafan/beats
that referenced
this pull request
Apr 28, 2023
) (cherry picked from commit 7aa51f1)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'd say we want to keep Jolokia autodiscover as is, so remove the experimental tag for 7.0.