Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Beat CRD docs #3362

Merged
merged 13 commits into from
Jul 2, 2020
Merged

Add Beat CRD docs #3362

merged 13 commits into from
Jul 2, 2020

Conversation

david-kow
Copy link
Contributor

@david-kow david-kow commented Jun 30, 2020

My first pass at the docs. I'm planning to add one more section (for config recipes) separately.

Resolves #3216.

Preview available.

@david-kow david-kow added >docs Documentation backport For backport PRs v1.2.0 :beats labels Jun 30, 2020
@david-kow david-kow requested a review from alaudazzi June 30, 2020 19:02
@david-kow david-kow changed the title Beat crd docs Add Beat CRD docs Jun 30, 2020
Copy link
Contributor

@alaudazzi alaudazzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left a few editing suggestions, otherwise LGTM.

@pebrc pebrc removed the backport For backport PRs label Jul 1, 2020
David Kowalski and others added 2 commits July 1, 2020 12:22
Copy link
Contributor

@sebgl sebgl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@david-kow david-kow requested a review from pebrc July 1, 2020 15:12
David Kowalski added 2 commits July 2, 2020 15:43
Copy link
Contributor

@anyasabo anyasabo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few nits left but LGTM, nice work!

@david-kow david-kow merged commit c48e3b4 into elastic:master Jul 2, 2020
@david-kow david-kow deleted the beat_crd_docs branch July 2, 2020 15:28
david-kow added a commit to david-kow/cloud-on-k8s that referenced this pull request Jul 2, 2020
* Add Beat docs

* Add troubleshooting section, fix typos

* Apply suggestions from code review

Co-authored-by: alaudazzi <[email protected]>

* PR fixes

* Apply suggestions from code review

Co-authored-by: Peter Brachwitz <[email protected]>

* PR fixes

* Apply suggestions from code review

Co-authored-by: Peter Brachwitz <[email protected]>

* PR fixes

* PR fixes

* PR fixes

* PR fixes

* Apply suggestions from code review

Co-authored-by: Anya Sabo <[email protected]>

* PR fixes

Co-authored-by: alaudazzi <[email protected]>
Co-authored-by: Peter Brachwitz <[email protected]>
Co-authored-by: Anya Sabo <[email protected]>
david-kow added a commit that referenced this pull request Jul 7, 2020
* Add Beat docs

* Add troubleshooting section, fix typos

* Apply suggestions from code review

Co-authored-by: alaudazzi <[email protected]>

* PR fixes

* Apply suggestions from code review

Co-authored-by: Peter Brachwitz <[email protected]>

* PR fixes

* Apply suggestions from code review

Co-authored-by: Peter Brachwitz <[email protected]>

* PR fixes

* PR fixes

* PR fixes

* PR fixes

* Apply suggestions from code review

Co-authored-by: Anya Sabo <[email protected]>

* PR fixes

Co-authored-by: alaudazzi <[email protected]>
Co-authored-by: Peter Brachwitz <[email protected]>
Co-authored-by: Anya Sabo <[email protected]>

Co-authored-by: alaudazzi <[email protected]>
Co-authored-by: Peter Brachwitz <[email protected]>
Co-authored-by: Anya Sabo <[email protected]>
david-kow added a commit to david-kow/cloud-on-k8s that referenced this pull request Jul 17, 2020
* Add Beat docs

* Add troubleshooting section, fix typos

* Apply suggestions from code review

Co-authored-by: alaudazzi <[email protected]>

* PR fixes

* Apply suggestions from code review

Co-authored-by: Peter Brachwitz <[email protected]>

* PR fixes

* Apply suggestions from code review

Co-authored-by: Peter Brachwitz <[email protected]>

* PR fixes

* PR fixes

* PR fixes

* PR fixes

* Apply suggestions from code review

Co-authored-by: Anya Sabo <[email protected]>

* PR fixes

Co-authored-by: alaudazzi <[email protected]>
Co-authored-by: Peter Brachwitz <[email protected]>
Co-authored-by: Anya Sabo <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
>docs Documentation v1.2.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Beats documentation
5 participants