-
Notifications
You must be signed in to change notification settings - Fork 723
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Beat CRD docs #3362
Add Beat CRD docs #3362
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left a few editing suggestions, otherwise LGTM.
Co-authored-by: alaudazzi <[email protected]>
Co-authored-by: Peter Brachwitz <[email protected]>
Co-authored-by: Peter Brachwitz <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few nits left but LGTM, nice work!
Co-authored-by: Anya Sabo <[email protected]>
* Add Beat docs * Add troubleshooting section, fix typos * Apply suggestions from code review Co-authored-by: alaudazzi <[email protected]> * PR fixes * Apply suggestions from code review Co-authored-by: Peter Brachwitz <[email protected]> * PR fixes * Apply suggestions from code review Co-authored-by: Peter Brachwitz <[email protected]> * PR fixes * PR fixes * PR fixes * PR fixes * Apply suggestions from code review Co-authored-by: Anya Sabo <[email protected]> * PR fixes Co-authored-by: alaudazzi <[email protected]> Co-authored-by: Peter Brachwitz <[email protected]> Co-authored-by: Anya Sabo <[email protected]>
* Add Beat docs * Add troubleshooting section, fix typos * Apply suggestions from code review Co-authored-by: alaudazzi <[email protected]> * PR fixes * Apply suggestions from code review Co-authored-by: Peter Brachwitz <[email protected]> * PR fixes * Apply suggestions from code review Co-authored-by: Peter Brachwitz <[email protected]> * PR fixes * PR fixes * PR fixes * PR fixes * Apply suggestions from code review Co-authored-by: Anya Sabo <[email protected]> * PR fixes Co-authored-by: alaudazzi <[email protected]> Co-authored-by: Peter Brachwitz <[email protected]> Co-authored-by: Anya Sabo <[email protected]> Co-authored-by: alaudazzi <[email protected]> Co-authored-by: Peter Brachwitz <[email protected]> Co-authored-by: Anya Sabo <[email protected]>
* Add Beat docs * Add troubleshooting section, fix typos * Apply suggestions from code review Co-authored-by: alaudazzi <[email protected]> * PR fixes * Apply suggestions from code review Co-authored-by: Peter Brachwitz <[email protected]> * PR fixes * Apply suggestions from code review Co-authored-by: Peter Brachwitz <[email protected]> * PR fixes * PR fixes * PR fixes * PR fixes * Apply suggestions from code review Co-authored-by: Anya Sabo <[email protected]> * PR fixes Co-authored-by: alaudazzi <[email protected]> Co-authored-by: Peter Brachwitz <[email protected]> Co-authored-by: Anya Sabo <[email protected]>
My first pass at the docs. I'm planning to add one more section (for config recipes) separately.
Resolves #3216.
Preview available.