Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle EnterpriseSearchRef in Kibana builder #8249

Merged
merged 1 commit into from
Nov 22, 2024
Merged

Conversation

thbkrkr
Copy link
Contributor

@thbkrkr thbkrkr commented Nov 21, 2024

This updates the Kibana test/builder to be able to use enterpriseSearchRef in Kibana resources defined in config/samples/*/* manifests.

Follow-up of #8166.

🧪 in local 🟢.

> TESTS_MATCH=TestSample m e2e-local
...
    --- PASS: TestSamples/enterprisesearch-ent_es (166.61s)
...
    --- PASS: TestSamples/kibana-kibana_es (134.58s)
...

@thbkrkr thbkrkr added >enhancement Enhancement of existing functionality >test Related to unit/integration/e2e tests labels Nov 21, 2024
@thbkrkr thbkrkr enabled auto-merge (squash) November 21, 2024 21:43
@thbkrkr
Copy link
Contributor Author

thbkrkr commented Nov 21, 2024

buildkite test this -f p=kind,t=TestSamples

@thbkrkr thbkrkr requested a review from naemono November 21, 2024 21:51
Copy link
Contributor

@barkbay barkbay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thbkrkr thbkrkr merged commit a3e7892 into main Nov 22, 2024
5 checks passed
@thbkrkr thbkrkr deleted the fix-testsamples-kb-entref branch November 22, 2024 07:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
>enhancement Enhancement of existing functionality >test Related to unit/integration/e2e tests v2.16.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants