Set basePath in Metricbeat when using stack monitoring #8311
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
buildkite test this -f t=Test.*StackMonitoring -m s=7.17.25,s=8.15.4 |
|
buildkite test this -f p=gke,t=Test.*StackMonitoring -m s=8.16.0,s=7.17.25,s=8.15.4 |
thbkrkr
approved these changes
Dec 11, 2024
| @@ -29,6 +29,7 @@ func NewMetricBeatSidecar( | |||
| baseConfigTemplate string, | |||
| namer name.Namer, | |||
| url string, | |||
| basePath string, | |||
There was a problem hiding this comment.
NewMetricBeatSidecar(..) and buildMetricbeatBaseConfig(..) start to have a lot of parameters. At some point, it might be reasonable to introduce a struct?
There was a problem hiding this comment.
I think fundamentally basePath should not be in the common stack monitoring code. But I wanted a quick fix we could include in the release. Ideally one would want a bit more more modular code where we can have application/module specific settings in the specific controllers.
pebrc
added a commit
to pebrc/cloud-on-k8s
that referenced
this pull request
Dec 11, 2024
Ensure stack monitoring works when Kibana is configured with a basePath parameter. (cherry picked from commit eadb46d)
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8310