feat(apm-server): use default image for ubi #8374
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
in 9.x ubi is the default and there's no -ubi image use a switch so other images can be added in a flexible way
barkbay
reviewed
Dec 30, 2024
There was a problem hiding this comment.
Let's maybe add some unit tests?
diff --git a/pkg/controller/common/container/container_test.go b/pkg/controller/common/container/container_test.go
index e2c088326..3a1e969de 100644
--- a/pkg/controller/common/container/container_test.go
+++ b/pkg/controller/common/container/container_test.go
@@ -28,6 +28,20 @@ func TestImageRepository(t *testing.T) {
version: "7.5.2",
want: testRegistry + "/apm/apm-server:7.5.2",
},
+ {
+ name: "APM server UBI image before 9.x",
+ image: APMServerImage,
+ version: "8.99.99",
+ suffix: "-ubi",
+ want: testRegistry + "/apm/apm-server-ubi:8.99.99",
+ },
+ {
+ name: "APM server UBI image since 9.x",
+ image: APMServerImage,
+ version: "9.0.0",
+ suffix: "-ubi",
+ want: testRegistry + "/apm/apm-server:9.0.0",
+ },
{
name: "Kibana image",
image: KibanaImage,
barkbay
reviewed
Dec 30, 2024
Co-authored-by: Michael Morello <[email protected]>
fyi I can't merge this :( |
I enabled auto-merge, this should be merged automatically once the tests are ✅ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
in 9.x ubi is the default and there's no -ubi image
use a switch so other images can be added in a flexible way
Related to elastic/apm-server#13872