-
Notifications
You must be signed in to change notification settings - Fork 516
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Rule Tuning] Interactive Terminal Spawned via Python #2781
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unit testing fix and a potential change of readibility / less easy to bypass (as most shell equivalents in Linux end with sh). Other than that, LGTM
Co-authored-by: Ruben Groenewoud <[email protected]>
* [Rule Tuning] Interactive Terminal Spawned via Python * Update execution_python_tty_shell.toml * Update execution_python_tty_shell.toml * Apply suggestions from code review Co-authored-by: Ruben Groenewoud <[email protected]> --------- Co-authored-by: Ruben Groenewoud <[email protected]> (cherry picked from commit 0d5e25e)
* [Rule Tuning] Interactive Terminal Spawned via Python * Update execution_python_tty_shell.toml * Update execution_python_tty_shell.toml * Apply suggestions from code review Co-authored-by: Ruben Groenewoud <[email protected]> --------- Co-authored-by: Ruben Groenewoud <[email protected]> (cherry picked from commit 0d5e25e)
* [Rule Tuning] Interactive Terminal Spawned via Python * Update execution_python_tty_shell.toml * Update execution_python_tty_shell.toml * Apply suggestions from code review Co-authored-by: Ruben Groenewoud <[email protected]> --------- Co-authored-by: Ruben Groenewoud <[email protected]> (cherry picked from commit 0d5e25e)
* [Rule Tuning] Interactive Terminal Spawned via Python * Update execution_python_tty_shell.toml * Update execution_python_tty_shell.toml * Apply suggestions from code review Co-authored-by: Ruben Groenewoud <[email protected]> --------- Co-authored-by: Ruben Groenewoud <[email protected]> (cherry picked from commit 0d5e25e)
* [Rule Tuning] Interactive Terminal Spawned via Python * Update execution_python_tty_shell.toml * Update execution_python_tty_shell.toml * Apply suggestions from code review Co-authored-by: Ruben Groenewoud <[email protected]> --------- Co-authored-by: Ruben Groenewoud <[email protected]> (cherry picked from commit 0d5e25e)
* [Rule Tuning] Interactive Terminal Spawned via Python * Update execution_python_tty_shell.toml * Update execution_python_tty_shell.toml * Apply suggestions from code review Co-authored-by: Ruben Groenewoud <[email protected]> --------- Co-authored-by: Ruben Groenewoud <[email protected]> (cherry picked from commit 0d5e25e)
@w0rk3r the updated rule seems to be creating a lot of false positives. It is being triggered by services that perform health checks and configuration checks. For example, OMS Agent in linux runs a python script which collects telemetry. This further spawns a bash shell that displays the process metrics. Not sure if this would be the ideal optimization but there could be a NOT process.command_line: (#All the commands to ignore) added in the query as well.
|
@okbud12, thanks for reporting, I'll take a look at it and push a tuning |
Summary
Brings #1649 back to life now that we support type changes