Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Tuning] Windows Discovery Rule Tuning for UEBA #3097
[Tuning] Windows Discovery Rule Tuning for UEBA #3097
Changes from 21 commits
b127b42
92ebe05
5df753f
1cb38b2
7750c9f
7cd5750
4778cb7
802a06b
d988c5c
2c18c5d
8e682a3
f6e9315
ef1779a
83f63b5
16d20fd
8fcae0e
120024a
2276eba
c50714a
59a7b5f
fec72d4
0b733e3
27d5f9b
f5367ae
4647b5d
c0dd576
299ce9e
da33c09
aee101f
2909d31
079c2c3
438f592
347716b
9ec4b71
26451b6
cc95dda
0428a43
ae154e3
522cc3e
85d11ed
2507943
97b1536
d6a8c3a
5f39660
f1585f7
eed00f9
1fbec65
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is this intended to exclude
PDQInventoryScanner.exe
byS-1-5-18
user or are these intended to be 2 separate exclusions?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These are two separate exclusions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just to make it more obvious
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
process.args.caseless
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ah, so it is not ingested as a multi-field.
What you can do instead then to retain the resiliency here is
I would test it too
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
outdated due to the BBR converions
Yea unfortunately we cannot use fields such as
process.parent.name.caseless
,process.parent.executable.caseless
,process.args.caseless
etc. Apparently, we can useprocess.command_line.caseless
(I did not know, so thanks!).This one would for example not execute on
cmd.exe /C ...
due to capitalization. However, the issue with it is, in KQL building queries with spaces and wildcards are a mess, as we can't use quotes like in your example above. What we can do is something like:Or building it into one query if we expect the
set
anddir
commands to be always used as first argument within the command:If we would change it to something like this:
We would capture way more FPs as it can trigger on chunks of commands. What do you think?