-
Notifications
You must be signed in to change notification settings - Fork 520
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Tuning] SDH - Possible Consent Grant Attack via Azure-Registered Application #4283
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SDH related rule tuning for o365.audit dataset
imays11
added
Domain: Cloud
Rule: Tuning
tweaking or tuning an existing rule
Integration: Microsoft 365
labels
Dec 5, 2024
imays11
requested review from
Mikaayenson,
w0rk3r,
DefSecSentinel,
Samirbous,
Aegrah,
shashank-elastic and
terrancedejesus
December 5, 2024 18:21
Rule: Tuning - GuidelinesThese guidelines serve as a reminder set of considerations when tuning an existing rule. Documentation and Context
Rule Metadata Checks
Testing and Validation
|
Samirbous
approved these changes
Dec 6, 2024
terrancedejesus
approved these changes
Dec 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
backport: auto
Domain: Cloud
Integration: Azure
azure related rules
Integration: Microsoft 365
Rule: Tuning
tweaking or tuning an existing rule
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Issue link(s):
https://github.com/elastic/sdh-protections/issues/538
Summary - What I changed
o365 integration had a field pipeline change that renamed the
o365.audit.Operation
field asevent.action
. Because of this the rule as it exists does not trigger foro365.audit
data stream. I'm adding theevent.action
field as an additional OR clause which should correct the false negative. This is a simple tuning that should work as expected below is a screenshot from @arturmouraa with the working query in his test environment as I do not have one set up for this at the moment and would like to push the change in time for our upcoming release.How To Test
target event provided in SDH ticket
SCREENSHOTS
Here is the screenshot of the alert after changing the rule query.
And here is the rule cloned and changed: