Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Copy images for inlinemediaobject #730

Closed
lcawl opened this issue Mar 16, 2019 · 0 comments
Closed

Copy images for inlinemediaobject #730

lcawl opened this issue Mar 16, 2019 · 0 comments
Assignees

Comments

@lcawl
Copy link
Contributor

lcawl commented Mar 16, 2019

Related to #541

If I use an inline image, it's not being copied to the output directory (thus resulting in a broken image).

For example, if I have a block image followed by an inline image:

image::xpack-tag.png[X-Pack]

image:test-star.png[Star]

It generates:

<div class="informalfigure"><div class="mediaobject"><img src="xpack-tag.png" alt="X-Pack" /></div></div><p><span class="inlinemediaobject"><img src="test-star.png" alt="Star" /></span></p>

But only the first file is copied to the output directory:

image

@nik9000 nik9000 self-assigned this Mar 18, 2019
nik9000 added a commit to nik9000/docs that referenced this issue Mar 20, 2019
This copies images declared "inline". Asciidoctor doesn't give a good
way of hooking into these images so we have to scan for them when we
walk the tree. It isn't the best solution, but at least we don't have to
scan for them after the document is rendered! If we did that we wouldn't
get line number information when we can't find images....

Closes elastic#730
nik9000 added a commit that referenced this issue Apr 1, 2019
This copies images declared "inline". Asciidoctor doesn't give a good
way of hooking into these images so we have to scan for them when we
walk the tree. It isn't the best solution, but at least we don't have to
scan for them after the document is rendered! If we did that we wouldn't
get line number information when we can't find images....

Closes #730
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants