-
Notifications
You must be signed in to change notification settings - Fork 338
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
elastic.co/guide/*
redesign
#2478
Conversation
I love where this is heading. One thing that we should change when we have time: the font in right-side TOC is too small relative to other text. I wonder if we should consider increasing the width of the page so that we do not have so much whitespace, and then we could increase the font size. |
Agreed. Our docs use Boostrap v4, which defines XL screens as anything above 1200 pixels. The screen recording above was taken on my laptop with a width of ~1400 pixels. There's a ton of whitespace in the recording because we use the docs/resources/web/lib/bootstrap/bootstrap.css Lines 615 to 619 in 0b1e761
I haven't done a lot of research, but it sounds like we can instead use the
Yeah, good point. That was me. We can definitely make it larger. |
[sticky otp/toc] Builds on elastic/docs elastic#2478
fix current_page_parent
check on various screen sizes
This is a great initiative! What do we think of making subheadings more visually distinct, i.e. render |
@colleenmcginnis recently brought up the topic of headings. We discussed it, but it might be beyond the scope of this PR. Changing the headings is a bit complex—mainly because of how Asciidoc converts We're planning on following up this PR with some elastic.co/guide changes. If it's okay, we can look at adding heading style changes into that PR. Thanks for the feedback! |
elastic.co/guide/*
redesign
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't feel particularly qualified to review the CSS or JavaScript changes, but I'm 👍🏻 for these changes as long as others approve. The pages look a lot better to me!
@glitteringkatie @chandlerprall would you have some time to review this, or nominate someone else who might be able to help? |
Thank you for leading this initiative! It looks much better than what we have today :-) |
@alaudazzi By "search for a term" do you mean use the site-wide search and click on a result (see screenshot below)? It looks like those links go to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM👍
I found some places where the page is scrolled instead of starting at the top like it should. I don't think this should be a blocker. I'm on Chrome Version 103.0.5060.134 (Official Build) (x86_64) pagescrolling.mp4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Checked for spacing, paragraph breaking, proper rendering, spot checks on various links etc.. LGTM. ( some of my nits are addressed in the PR.)
☝️ @bmorelli25 that commit switches from |
@lcawl TBH for most "books" I wish we could just skip the initial list and go directly to content. In most cases, the list page does not add value. I think there are some books that have introductory text on this page in addition to the list. Maybe as a next step we could try to beef up the introductory text for each book? Just a thought, not a hard requirement. |
I love the new redesign, really great grassroots effort to improve our docs 💯 😍 Now that the site is live, a lot of the feedback I've heard is very positive. I heard some constructive feedback, too. Listing it here (if there's another place to put this, please let me know):
Nothing super actionable, just sharing. |
Click here to view the interactive preview
Summary
This PR updates the style and layout of our
elastic.co/guide/*
documentation.Page
Table of contents (left column)
On this page & marketing (right column)
IntersectionObserver()
to highlight one item at a time in the "On this page" list.Why?
Our documentation is difficult to navigate, and readers constantly have to scroll up and down to maintain context or navigate to new pages. There are a number of reasons why this happens:
What does it look like?
Click here to view the interactive preview
Known limitations
Stakeholders
Others?
QA
Sorry, this is an internal link. Bug history and QA checklist.