Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch APM Agent for Ruby to Asciidoctor #715

Merged
merged 1 commit into from
Mar 14, 2019

Conversation

nik9000
Copy link
Member

@nik9000 nik9000 commented Mar 13, 2019

Switches the core of the build for the APM Agent for Ruby docs from the
end-of-life AsciiDoc to the actively maintained Asciidoctor. The HTML
differences are mostly whitespace but there are two "real" differences:

  1. The edit url for the section at api.html#api-context goes to
    index.asciidoc in AsciiDoc and api.asciidoc in AsciiDoctor.
    AsciiDoctor seems more right here.
  2. Empty table cells do not have an empty paragraph tag in them.

Switches the core of the build for the APM Agent for Ruby docs from the
end-of-life AsciiDoc to the actively maintained Asciidoctor. The HTML
differences are mostly whitespace but there are two "real" differences:
1. The edit url for the section at `api.html#api-context` goes to
`index.asciidoc` in AsciiDoc and `api.asciidoc` in AsciiDoctor.
AsciiDoctor seems more right here.
2. Empty table cells do not have an empty paragraph tag in them.
Copy link
Member

@bmorelli25 bmorelli25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@nik9000 nik9000 merged commit 61d7913 into elastic:master Mar 14, 2019
@nik9000 nik9000 mentioned this pull request Mar 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants