Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch legacy reporting docs to Asciidoctor #816

Merged
merged 1 commit into from
Apr 15, 2019

Conversation

nik9000
Copy link
Member

@nik9000 nik9000 commented Apr 12, 2019

Switches the core of the build for the legacy reporting docs from
AsciiDoc to Asciidoctor.

Switches the core of the build for the legacy reporting docs from
AsciiDoc to Asciidoctor.
@nik9000 nik9000 requested a review from lcawl April 12, 2019 17:49
Copy link
Contributor

@lcawl lcawl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I compared the output visually and it LGTM, thanks!

@nik9000 nik9000 merged commit 9c3889e into elastic:master Apr 15, 2019
@nik9000
Copy link
Member Author

nik9000 commented Apr 15, 2019

Thanks for reviewing @lcawl! I forgot to leave a diff on this one because it was prety much empty iirc.

@nik9000 nik9000 mentioned this pull request Apr 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants