This repository has been archived by the owner on Sep 17, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 41
fix: honor ELASTIC_AGENT_VERSION when downloading the agent #480
Merged
mdelapenya
merged 2 commits into
elastic:master
from
mdelapenya:287-document-regression-tests
Dec 1, 2020
Merged
fix: honor ELASTIC_AGENT_VERSION when downloading the agent #480
mdelapenya
merged 2 commits into
elastic:master
from
mdelapenya:287-document-regression-tests
Dec 1, 2020
+11
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jenkins run the tests please |
cachedout
approved these changes
Dec 1, 2020
10 tasks
kuisathaverat
approved these changes
Dec 1, 2020
mdelapenya
added a commit
to mdelapenya/e2e-testing
that referenced
this pull request
Dec 1, 2020
mdelapenya
added a commit
to mdelapenya/e2e-testing
that referenced
this pull request
Dec 1, 2020
No need to backport this to 7.9.x, as the TAR installer support is not available in that maintenance branch |
8 tasks
mdelapenya
added a commit
to mdelapenya/e2e-testing
that referenced
this pull request
Dec 3, 2020
mdelapenya
added a commit
to mdelapenya/e2e-testing
that referenced
this pull request
Dec 3, 2020
This was referenced Dec 3, 2020
mdelapenya
added a commit
that referenced
this pull request
Dec 3, 2020
mdelapenya
added a commit
that referenced
this pull request
Dec 3, 2020
8 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
It checks if the environment variable used to override Agent's version is set. If it's not set, then it will use the base version, which is obtained from:
a. the Elastic Artifacts URL for aliases (7.x, 7.10.x),
b. fixed to the maintenance branch
c. 8.0.0-SNAPSHOT in the master branch
Why is it important?
I found that running:
was always downloading the version set to the maintenance branch, not honoring the version set in the environment variable.
Because we evaluated the version just once (init method for the test suite), then further calculations were tied to thee base version.
Checklist
make notice
in the proper directory)How to test this PR locally
Download a different agent version (7.10.1)
Download the default agent version (8.0.0-SNAPSHOT)
Related issues