Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make all fields under log.origin.* be consistently nested #120

Merged
merged 3 commits into from
Jan 21, 2021

Conversation

felixbarny
Copy link
Member

e.g. "log":{"origin":{"file":{"name": "Foo.java"}}} instead of"log.origin":{"file.name": "Foo.java"}

Extend validator to check top_level_field and lookup both nested and dotted fields.

Note: log.level and log.logger remain to be dotted fields.

e.g. log{origin{file{name: Foo.java}}} instead log.origin{file.name: Foo.java}

Extend validator to check top_level_field and lookup both nested and dotted fields
@apmmachine
Copy link
Contributor

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: Pull request #120 opened

    • Start Time: 2021-01-20T15:00:14.203+0000
  • Duration: 7 min 52 sec

  • Commit: bcb1635

Test stats 🧪

Test Results
Failed 0
Passed 144
Skipped 4
Total 148

@felixbarny felixbarny merged commit fbc5f63 into elastic:master Jan 21, 2021
@felixbarny felixbarny deleted the nested-log-origin branch January 21, 2021 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants