Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes it easier to set ECS fields via MDC.
Previously, you'd have to configure
topLevelLabels
for each ECS field added via MDC.Now, if you want to have a field nested under labels, you have to explicitly prefix it with
labels.
.This increases the chance of conflicts, for example when the user adds an
@timestamp
MDC value. But it also gets out of the way for legitimate use cases.Having to whitelist all MDC values that should be serialized at the top level via
topLevelLabels
is cumbersome and feels inconsistent. I think it's overly protective.