Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add service.environment and service.version fields to the spec #70

Closed
wants to merge 1 commit into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions spec/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -74,6 +74,8 @@ The following example describes a richer set of fields in an event that has not
"trace.id": "4bf92f3577b34da6a3ce929d0e0e4736",
"transaction.id": "00f067aa0ba902b7",
"service.name": "opbeans",
"service.environment": "production",
"service.version": "1.2.3",
"event.dataset": "opbeans.log"
}
```
Expand Down
18 changes: 18 additions & 0 deletions spec/spec.json
Original file line number Diff line number Diff line change
Expand Up @@ -76,6 +76,24 @@
"When an APM agent is active, it should auto-configure this field if not already set."
]
},
"service.environment": {
"type": "string",
"required": false,
"url": "https://www.elastic.co/guide/en/ecs/current/ecs-service.html#field-service-environment",
"comment": [
"Configurable by users.",
"When an APM agent is active, it should auto-configure this field if not already set."
]
},
"service.version": {
"type": "string",
"required": false,
"url": "https://www.elastic.co/guide/en/ecs/current/ecs-service.html#field-service-version",
"comment": [
"Configurable by users.",
"When an APM agent is active, it should auto-configure this field if not already set."
]
},
"service.node.name": {
"type": "string",
"required": false,
Expand Down