Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1.5] Prepare link to Logs docs changing with the 7.10 release in "getting-started" (#1073) #1082

Merged
merged 1 commit into from
Nov 4, 2020

Conversation

webmat
Copy link
Contributor

@webmat webmat commented Nov 4, 2020

Backports the following commits to 1.5:

@webmat webmat self-assigned this Nov 4, 2020
@webmat webmat added the backport label Nov 4, 2020
@webmat
Copy link
Contributor Author

webmat commented Nov 4, 2020

@ebeahan This backport is failing because of the chunking change we did recently. Can you recall what needs to be done here?

These doc backports all the way back to the bronze age happen every once in a while. I wonder if break will happen every time we backport a link fix to 1.5?

@ebeahan
Copy link
Member

ebeahan commented Nov 4, 2020

I've identified the issue; I missed including the necessary generator changes when I added the [discrete] headers in the 1.5 branch.

@webmat
Copy link
Contributor Author

webmat commented Nov 4, 2020

Yeah I wonder if you had done those manually, to avoid having to modify multiple different past versions of the scripts.

If that was the case, this isn't a blocker for this backport. But we should consider fixing the script anyway, if it's a small fix. I wouldn't want to wonder why the build is failing every other release, when we backport fixes to broken links to older versions of the doc :-)

@ebeahan
Copy link
Member

ebeahan commented Nov 4, 2020

I had the changes done locally, but I overlooked committing them 🤕

Script fix: #1089

@webmat webmat force-pushed the backport/1.5/pr-1073 branch from 194b4d8 to a518d18 Compare November 4, 2020 21:23
Copy link
Member

@ebeahan ebeahan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@webmat webmat merged commit 1efe50d into elastic:1.5 Nov 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants