Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding field vendor.name to Package ECS mapping #2205

Closed

Conversation

epicsilence99
Copy link

Pull request to add vendor name as an ECS field for the package ECS mappings to accompany the already existing fields such as package version and package name

@epicsilence99 epicsilence99 requested a review from a team as a code owner May 1, 2023 13:43
@cla-checker-service
Copy link

cla-checker-service bot commented May 1, 2023

❌ Author of the following commits did not sign a Contributor Agreement:
17b742b, 18c867e

Please, read and sign the above mentioned agreement if you want to contribute to this project

@epicsilence99
Copy link
Author

❌ Author of the following commits did not sign a Contributor Agreement: 17b742b

Please, read and sign the above mentioned agreement if you want to contribute to this project

I have already signed earlier this morning

@epicsilence99
Copy link
Author

This PR links to feature request submitted here:
#2203

@kgeller
Copy link
Contributor

kgeller commented May 1, 2023

I have already signed earlier this morning

@lkuik It appears that you signed the CLA with a different email address (internet provider email) than was associated with the commit (company email).

@epicsilence99
Copy link
Author

My apologies @kgeller , not sure why it ended up committing with the wrong userid.
Is best path forward to just close this out cancel the PR, and resubmit and ensure the commit is with my personal github?

@epicsilence99
Copy link
Author

Closing this PR out as was submitted with wrong GitHub ID, will re-submit to match ID on file for CLA

@epicsilence99 epicsilence99 deleted the lkuik/package-ecs-enhancement branch May 1, 2023 15:10
@kgeller
Copy link
Contributor

kgeller commented May 1, 2023

@lkuik no problem! I see it's already complete, but yes the best path is to have that cla signed with whatever is associated with the commit.

@epicsilence99
Copy link
Author

epicsilence99 commented May 1, 2023 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants