Logshints #83
Merged
Logshints #83
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gizas
requested review from
MichaelKatsoulis,
tetianakravchenko and
constanca-m
MichaelKatsoulis
approved these changes
Apr 1, 2024
belimawr
requested changes
Apr 3, 2024
utils/hints_test.go
Outdated
| "co.elastic.hints/package": "apache", | ||
| "co.elastic.hints/data_streams": "access,error", | ||
| "co.elastic.hints/access.period": "5m", | ||
| "co.elastic.hints/access.streams": "stdout", // On purpose this added with typo |
There was a problem hiding this comment.
I'm having a hard time understanding the typo here. As it is a test, it would be easier to understand if the typo is very clear.
My suggestion is that instead of using a common mistake, like instead of using 'stream'/'streams', you can use 'stream'/'streamsssss'. Something that even on a quick glance anyone can notice why it is a typo.
There was a problem hiding this comment.
The same applies to the other ones on this PR.
There was a problem hiding this comment.
@belimawr can you please have another look?
There was a problem hiding this comment.
Sorry for the delay @gizas for some reason I didn't get the email for this ping :/
constanca-m
reviewed
Apr 9, 2024
constanca-m
approved these changes
Apr 9, 2024
💚 Build Succeeded
History
|
belimawr
approved these changes
Apr 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuation of #81
We enhance the autodiscovery checks for supported hints to check multiple data_streams (in case of agent) and multiple metrcisets (in case of beats)