Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI: fix linter config issue #118

Merged
merged 2 commits into from
Nov 24, 2023
Merged

CI: fix linter config issue #118

merged 2 commits into from
Nov 24, 2023

Conversation

florianl
Copy link
Member

@florianl florianl commented Nov 24, 2023 •
edited
Loading

What does this PR do?

[Invalid workflow file: .github/workflows/golangci-lint.yml#L57](https://github.com/elastic/elastic-agent-system-metrics/actions/runs/6978945111/workflow)
You have an error in your yaml syntax on line 57
  • Update CI dependencies like actions/checkout and actions/setup-go to latest version
  • Align golangci-lint version to v1.55.2

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.md

@florianl
CI: fix linter config issue
fffadb5 
Signed-off-by: Florian Lehner <[email protected]>
@florianl florianl added bug Something isn't working Team:Elastic-Agent Label for the Agent team labels Nov 24, 2023
@florianl florianl requested a review from a team as a code owner November 24, 2023 09:33
@florianl florianl requested review from fearful-symmetry and faec and removed request for a team November 24, 2023 09:33
@florianl
update from 1.47.2 to 1.55.2
ff60201 
Signed-off-by: Florian Lehner <[email protected]>
cmacknz
cmacknz approved these changes Nov 24, 2023
View reviewed changes
Copy link
Member

@cmacknz cmacknz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@florianl florianl merged commit 1356e2a into main Nov 24, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cmacknz cmacknz cmacknz approved these changes

@fearful-symmetry fearful-symmetry Awaiting requested review from fearful-symmetry fearful-symmetry is a code owner automatically assigned from elastic/elastic-agent-data-plane

@faec faec Awaiting requested review from faec faec is a code owner automatically assigned from elastic/elastic-agent-data-plane

Assignees
No one assigned
Labels
bug Something isn't working Team:Elastic-Agent Label for the Agent team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@florianl @cmacknz