CI: remove deprecated skip-go-install option #119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skip-go-install was removed with golangci/golangci-lint-action@423fbaf. Signed-off-by: Florian Lehner <[email protected]>
florianl
requested review from
ycombinator and
rdner
and removed request for
a team
Signed-off-by: Florian Lehner <[email protected]>
florianl
commented
Nov 28, 2023
| - typecheck # Like the front-end of a Go compiler, parses and type-checks Go code | ||
| - varcheck # Finds unused global variables and constants |
There was a problem hiding this comment.
level=warning msg="[runner] The linter 'varcheck' is deprecated (since v1.49.0) due to: The owner seems to have abandoned the linter. Replaced by unused."
florianl
commented
Nov 28, 2023
| @@ -32,9 +32,7 @@ linters: | |||
| - unused # checks Go code for unused constants, variables, functions and types | |||
| - govet # Vet examines Go source code and reports suspicious constructs, such as Printf calls whose arguments do not align with the format string | |||
| - ineffassign # detects when assignments to existing variables are not used | |||
| - structcheck # finds unused struct fields | |||
There was a problem hiding this comment.
level=warning msg="[runner] The linter 'structcheck' is deprecated (since v1.49.0) due to: The owner seems to have abandoned the linter. Replaced by unused."
cmacknz
approved these changes
Nov 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
skip-go-installwas removed withgolangci/golangci-lint-action@423fbaf. As this optional argument is still used in golangci-lint-action, the action fails with:
https://github.com/elastic/elastic-agent-system-metrics/actions/runs/7017910507/job/19092190110#step:6:1