Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add windows arm support #179

Merged
merged 3 commits into from
Sep 3, 2024

Conversation

kruskall
Copy link
Member

@kruskall kruskall commented Sep 1, 2024

What does this PR do?

rename 386/amd64 specific files to compile on windows and use build tags to check the architecture

Why is it important?

add windows/arm and windows/arm64 support

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.md

Author's Checklist

  • [ ]

Related issues

rename 386/amd64 specific files to compile on windows and use
build tags to check the architecture
@kruskall kruskall requested a review from a team as a code owner September 1, 2024 15:30
@kruskall kruskall requested review from belimawr and VihasMakwana and removed request for a team September 1, 2024 15:30
Copy link
Contributor

@belimawr belimawr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not a big deal, but I'd have kept the build tags for windows in the file.

@kruskall kruskall merged commit 162375b into elastic:main Sep 3, 2024
5 checks passed
@kruskall kruskall deleted the feat/windows-arm-support branch September 3, 2024 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants