Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "[updatecli][githubrelease] Bump version to 1.19.8 (#2475)" #2515

Merged
merged 1 commit into from
Apr 19, 2023

Conversation

cmacknz
Copy link
Member

@cmacknz cmacknz commented Apr 19, 2023

This reverts commit 732ad1f.

See #2475 (comment).

We need to wait for elastic/golang-crossbuild#282 to be resolved before merging this.

@cmacknz cmacknz self-assigned this Apr 19, 2023
@cmacknz cmacknz requested a review from a team as a code owner April 19, 2023 01:44
@cmacknz cmacknz requested review from michalpristas and blakerouse and removed request for a team April 19, 2023 01:44
@mergify
Copy link
Contributor

mergify bot commented Apr 19, 2023

This pull request does not have a backport label. Could you fix it @cmacknz? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-v./d./d./d is the label to automatically backport to the 8./d branch. /d is the digit

NOTE: backport-skip has been added to this pull request.

@cmacknz cmacknz requested a review from ycombinator April 19, 2023 01:46
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-04-19T01:45:06.358+0000

  • Duration: 21 min 21 sec

Test stats 🧪

Test Results
Failed 0
Passed 5535
Skipped 19
Total 5554

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages.

  • run integration tests : Run the Elastic Agent Integration tests.

  • run end-to-end tests : Generate the packages and run the E2E Tests.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@elasticmachine
Copy link
Contributor

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 98.529% (67/68) 👍
Files 68.22% (161/236) 👍
Classes 67.785% (303/447) 👍
Methods 54.111% (928/1715) 👍
Lines 39.638% (10510/26515) 👍 0.019
Conditionals 100.0% (0/0) 💚

@ycombinator
Copy link
Contributor

We need to wait for elastic/golang-crossbuild#282 to be resolved before merging this.

I think this revert PR should be merged right away so main builds are passing again, no?

The PR whose changes this PR reverts - #2475 - is the one we'd want to wait on reopening and merging until elastic/golang-crossbuild#282 is resolved and merged first, yes?

@cmacknz cmacknz merged commit 59fec54 into elastic:main Apr 19, 2023
@cmacknz cmacknz deleted the revert-go-version-bump branch April 19, 2023 13:11
@cmacknz
Copy link
Member Author

cmacknz commented Apr 19, 2023

I think this revert PR should be merged right away so main builds are passing again, no?

Yes I mistakenly copied the text about waiting into this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants