Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide --base-path flag for install sub-command #2592

Merged
merged 6 commits into from
May 3, 2023

Conversation

ycombinator
Copy link
Contributor

@ycombinator ycombinator commented May 2, 2023

What does this PR do?

This PR "reverts" the feature introduced in #2500 by hiding the --base-path CLI flag for the install sub-command.

The rest of the changes introduced in #2500 and it's follow up PR, #2567, are preserved to allow us to easily reintroduce this feature at a later time.

Why is it important?

The --base-path value has no effect on the installation base path of Endpoint. As such, we don't want to release a half-baked feature that only works for some Agent-managed components but not all.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation: Revert "Add instructions on customizing installation base path for Elastic Agent" ingest-docs#189
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in ./changelog/fragments using the changelog tool: Feature is being reverted from same release it was introduced in.
  • I have added an integration test or an E2E test

@mergify
Copy link
Contributor

mergify bot commented May 2, 2023

This pull request does not have a backport label. Could you fix it @ycombinator? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-v./d./d./d is the label to automatically backport to the 8./d branch. /d is the digit

NOTE: backport-skip has been added to this pull request.

@mergify mergify bot added the backport-skip label May 2, 2023
@elasticmachine
Copy link
Contributor

elasticmachine commented May 2, 2023

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-05-02T22:02:53.179+0000

  • Duration: 19 min 7 sec

Test stats 🧪

Test Results
Failed 0
Passed 5585
Skipped 21
Total 5606

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages.

  • run integration tests : Run the Elastic Agent Integration tests.

  • run end-to-end tests : Generate the packages and run the E2E Tests.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@ycombinator ycombinator marked this pull request as ready for review May 2, 2023 15:27
@ycombinator ycombinator requested a review from a team as a code owner May 2, 2023 15:27
@ycombinator ycombinator requested review from AndersonQ and michalpristas and removed request for a team May 2, 2023 15:27
@elasticmachine
Copy link
Contributor

elasticmachine commented May 2, 2023

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 98.551% (68/69) 👍
Files 69.198% (164/237) 👍
Classes 68.304% (306/448) 👍
Methods 54.251% (938/1729) 👍
Lines 39.533% (10622/26869) 👎 -0.046
Conditionals 100.0% (0/0) 💚

@pierrehilbert pierrehilbert added the Team:Elastic-Agent Label for the Agent team label May 2, 2023
@ycombinator ycombinator requested review from cmacknz and blakerouse May 2, 2023 17:21
Copy link
Member

@cmacknz cmacknz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@cmacknz
Copy link
Member

cmacknz commented May 2, 2023

I suppose if we wanted a test for this, we would have a test to ensure the the --base-path argument is ignored or treated as invalid.

@ycombinator ycombinator changed the title Remove --base-path flag from install command Hide --base-path flag for install sub-command May 2, 2023
@ycombinator ycombinator requested review from cmacknz and blakerouse May 2, 2023 22:00
Copy link
Contributor

@blakerouse blakerouse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Easy! Like it!

@ycombinator ycombinator merged commit 1131f11 into elastic:main May 3, 2023
@ycombinator ycombinator deleted the install-remove-base-path-flag branch May 3, 2023 01:37
@ycombinator ycombinator added the backport-v8.8.0 Automated backport with mergify label May 3, 2023
mergify bot pushed a commit that referenced this pull request May 3, 2023
* Remove `--base-path` flag from `install` command

* Adding test skips

* Reference PR

* Mark flag as hidden

* Make linter happy

* Re-formatting

(cherry picked from commit 1131f11)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-v8.8.0 Automated backport with mergify Team:Elastic-Agent Label for the Agent team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants