-
Notifications
You must be signed in to change notification settings - Fork 154
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hide --base-path
flag for install
sub-command
#2592
Hide --base-path
flag for install
sub-command
#2592
Conversation
This pull request does not have a backport label. Could you fix it @ycombinator? 🙏
NOTE: |
🌐 Coverage report
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
I suppose if we wanted a test for this, we would have a test to ensure the the |
--base-path
flag from install
command--base-path
flag for install
sub-command
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Easy! Like it!
* Remove `--base-path` flag from `install` command * Adding test skips * Reference PR * Mark flag as hidden * Make linter happy * Re-formatting (cherry picked from commit 1131f11)
What does this PR do?
This PR "reverts" the feature introduced in #2500 by hiding the
--base-path
CLI flag for theinstall
sub-command.The rest of the changes introduced in #2500 and it's follow up PR, #2567, are preserved to allow us to easily reintroduce this feature at a later time.
Why is it important?
The
--base-path
value has no effect on the installation base path of Endpoint. As such, we don't want to release a half-baked feature that only works for some Agent-managed components but not all.Checklist
I have made corresponding change to the default configuration filesI have added tests that prove my fix is effective or that my feature worksI have added an entry in: Feature is being reverted from same release it was introduced in../changelog/fragments
using the changelog toolI have added an integration test or an E2E test