Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Add filebeat receiver to otel mode (#5672)" #5709

Merged
merged 1 commit into from
Oct 7, 2024

Conversation

ycombinator
Copy link
Contributor

This reverts commit bd219d6.

If we don't revert the aforementioned commit, Elastic Agent is unable to bootstrap Fleet Server with an unlimited timeout waiting for Fleet Server to start up, specified via --fleet-server-timeout -1, resulting in this error:

Error: invalid argument "--1s" for "--fleet-server-timeout" flag: time: invalid duration "--1s"

The fix for this problem is actually in elastic/beats#41136 but it might be a while before that PR is reviewed and merged. So the plan now is to:

  1. Revert bd219d6 (via this PR here)
  2. Get Move backwards compatible flag manipulation beats#41136 merged.
  3. Revert this revert PR here.

@ycombinator ycombinator requested a review from a team as a code owner October 4, 2024 22:09
Copy link
Contributor

mergify bot commented Oct 4, 2024

This pull request does not have a backport label. Could you fix it @ycombinator? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-./d./d is the label to automatically backport to the 8./d branch. /d is the digit

Copy link
Contributor

mergify bot commented Oct 4, 2024

backport-v8.x has been added to help with the transition to the new branch 8.x.
If you don't need it please use backport-skip label and remove the backport-8.x label.

@mergify mergify bot added the backport-8.x Automated backport to the 8.x branch with mergify label Oct 4, 2024
@ycombinator ycombinator requested review from cmacknz, blakerouse and leehinman and removed request for michel-laterman and swiatekm October 4, 2024 22:11
@ycombinator ycombinator added backport-skip and removed backport-8.x Automated backport to the 8.x branch with mergify labels Oct 4, 2024
@pierrehilbert
Copy link
Contributor

/test

Copy link

@jlind23 jlind23 merged commit dead4dc into elastic:main Oct 7, 2024
14 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants