-
Notifications
You must be signed in to change notification settings - Fork 154
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add filebeat receiver to otel mode #5833
Conversation
This pull request does not have a backport label. Could you fix it @leehinman? 🙏
|
|
1db94a4
to
0d899d6
Compare
Pinging @elastic/elastic-agent-control-plane (Team:Elastic-Agent-Control-Plane) |
This pull request is now in conflicts. Could you fix it? 🙏
|
0d899d6
to
bb5683c
Compare
@leehinman FYI I edited your PR description to fix the otel config. |
bb5683c
to
8412f73
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, tested locally and was able to run the filebeat receiver and confirm the data is properly exported to the file output.
8412f73
to
af78e6e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excited to see this back! Looks good.
The error we got in CI is:
Which looks similar to - elastic/beats#41270 |
af78e6e
to
2b075c1
Compare
This pull request is now in conflicts. Could you fix it? 🙏
|
1e4d44a
to
f97630f
Compare
Triggered another test run. Let's see if the build succeeds this time around. |
70b0307
to
cecc756
Compare
@rdner Looks like this is missing an approval from you, would you mind taking a look? Thanks. |
d6c9546
to
94c2189
Compare
94c2189
to
c272ca4
Compare
|
(cherry picked from commit 89dca1d) # Conflicts: # NOTICE.txt # go.mod # go.sum
This is amazing! |
(cherry picked from commit 89dca1d) # Conflicts: # NOTICE.txt # go.mod # go.sum
* Add filebeat receiver to otel mode (#5833) Co-authored-by: Lee E Hinman <[email protected]> Co-authored-by: Lee E. Hinman <[email protected]>
What does this PR do?
Adds filebeat receiver as an otel receiver. This is a re-introduction of code that was added in #5672, that had to be reverted because the import of the beats code base was causing issues with command line parsing. The issues in the beats code base have been fixed, so we are re-introducing this change.
Why is it important?
This is the first beat receiver, and this will allow us to test the feasibility of running beats as otel receivers.
Checklist
./changelog/fragments
using the changelog toolDisruptive User Impact
should be 0 user impact of existing configurations
How to test this PR locally
Use something like the following as
otel.yml
, and runelastic-agent otel --config otel.yml
This will run the beat receiver, which will produce one event.
The event should be written to the path you specify in the
file/no_rotation
section.Related issues
Questions to ask yourself