[helm] agent preset replicas #5981
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pkoutsovasilis
added
bug
|
Pinging @elastic/elastic-agent-control-plane (Team:Elastic-Agent-Control-Plane) |
pkoutsovasilis
changed the title
swiatekm
approved these changes
Nov 8, 2024
|
mergify bot
pushed a commit
that referenced
this pull request
Nov 8, 2024
* fix: set correct replicas of deployment and statefulset presets * fix: examples markdown fixes (cherry picked from commit f994f5b)
7 tasks
mergify bot
pushed a commit
that referenced
this pull request
Nov 8, 2024
* fix: set correct replicas of deployment and statefulset presets * fix: examples markdown fixes (cherry picked from commit f994f5b)
7 tasks
pierrehilbert
pushed a commit
that referenced
this pull request
Nov 8, 2024
* fix: set correct replicas of deployment and statefulset presets * fix: examples markdown fixes (cherry picked from commit f994f5b) Co-authored-by: Panos Koutsovasilis <[email protected]>
pkoutsovasilis
added a commit
that referenced
this pull request
Nov 8, 2024
* fix: set correct replicas of deployment and statefulset presets * fix: examples markdown fixes (cherry picked from commit f994f5b) Co-authored-by: Panos Koutsovasilis <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR sets correctly the replicas of agent presets (including the value of
0) and fixes some markdown issues in the chart examplesWhy is it important?
Because users should be able scale presets according to their needs
Checklist
./changelog/fragmentsusing the changelog toolDisruptive User Impact
N/A
How to test this PR locally
Follow kubernetes example and in the install command add this
--set agent.presets.clusterWide.replicaCount=2or--set agent.presets.clusterWide.replicaCount=0Related issues
N/A