Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Paginated heatmap shows tooltip outside the projection area #1215

Closed
markov00 opened this issue Jun 22, 2021 · 1 comment · Fixed by #1351 or elastic/kibana#113968
Closed

Paginated heatmap shows tooltip outside the projection area #1215

markov00 opened this issue Jun 22, 2021 · 1 comment · Fixed by #1351 or elastic/kibana#113968
Assignees
@rshen91
Labels
bug Something isn't working :heatmap Heatmap/Swimlane chart related issue Impact:High :interactions Interactions related issue released Issue released publicly :tooltip Related to hover tooltip

Comments

@markov00
Copy link
Member

markov00 commented Jun 22, 2021 •
edited
Loading

Describe the bug
A heatmap can be paginated: depending on the cell/grid configuration is possible to reduce the number of rows shown to fit into the screen.
We track the mouse position outside the projection area. The geometry picking logic doesn't exclude the non-rendered cells causing the tooltip to appear when hovering near the axis but outside the projection area.

To Reproduce
Steps to reproduce the behavior:

  1. Go to https://elastic.github.io/elastic-charts/?path=/story/heatmap-alpha--categorical
  2. move the mouse near the bottom part of the chart, over the x axis
  3. the tooltip, related to non-visible cells will appear

Expected behaviour
The tooltip should only be active for the visible cells

Screenshots
Jun-22-2021 19-54-38

Version (please complete the following information):

  • Elastic Charts: 30.x

Additional context
n/a

Errors in browser console
n/a
@markov00 markov00 added bug Something isn't working :heatmap Heatmap/Swimlane chart related issue :interactions Interactions related issue :tooltip Related to hover tooltip labels Jun 22, 2021
@markov00 markov00 mentioned this issue Jun 22, 2021
Merged
12 tasks
@rshen91 rshen91 self-assigned this Sep 1, 2021
@rshen91 rshen91 mentioned this issue Sep 1, 2021
Merged
3 tasks
rshen91 added a commit that referenced this issue Sep 3, 2021
@rshen91
fix(heatmap): filter out tooltip picked shapes in x-axis area (#1351)
174047d 
Closes #1215
nickofthyme pushed a commit that referenced this issue Sep 13, 2021
@semantic-release-bot
chore(release): 35.0.0 [skip ci]
b82f724 
# [35.0.0](v34.2.1...v35.0.0) (2021-09-13)

### Bug Fixes

* **a11y:** restore focus after popover close with color picker ([#1272](#1272)) ([0c6f945](0c6f945)), closes [#1266](#1266) [#935](#935)
* **build:** fix license in package.json ([#1362](#1362)) ([d524fdf](d524fdf))
* **deps:** update dependency @elastic/eui to ^37.5.0 ([#1341](#1341)) ([fb05c98](fb05c98))
* **deps:** update dependency @elastic/eui to ^37.6.1 ([#1359](#1359)) ([2ae90ce](2ae90ce))
* **deps:** update dependency @elastic/eui to ^37.7.0 ([#1373](#1373)) ([553b6b0](553b6b0))
* **heatmap:** filter out tooltip picked shapes in x-axis area ([#1351](#1351)) ([174047d](174047d)), closes [#1215](#1215)
* **heatmap:** remove values when brushing only over axes ([#1364](#1364)) ([77ff8d3](77ff8d3))

### Features

* **annotations:** add onClickHandler for annotations ([#1293](#1293)) ([48198be](48198be)), closes [#1211](#1211)
* **heatmap:** add text color contrast to heatmap cells ([#1342](#1342)) ([f9a26ef](f9a26ef)), closes [#1296](#1296)
* **heatmap:** reduce font size to fit label within cells ([#1352](#1352)) ([16b5546](16b5546))
* **xy:** mutilayer time axis step 1 ([#1326](#1326)) ([867b1f5](867b1f5))

### BREAKING CHANGES

* **xy:** - feat: removes the axis deduplication feature
- fix: `showDuplicatedTicks` causes a duplication check on the actual axis tick label (possibly yielded by `Axis.tickLabel` rather than the more general `tickFormat`)
* **heatmap:** the `config.label.fontSize` prop is replaced by `config.label.minFontSize` and `config.label.maxFontSize`. You can specify the same value for both properties to have a fixed font size. The `config.label.align` and `config.label.baseline` props are removed from the `HeatmapConfig` object.
@nickofthyme
Copy link
Collaborator

🎉 This issue has been resolved in version 35.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@nickofthyme nickofthyme added the released Issue released publicly label Sep 13, 2021
@markov00 markov00 mentioned this issue Oct 5, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rshen91 rshen91

Labels
bug Something isn't working :heatmap Heatmap/Swimlane chart related issue Impact:High :interactions Interactions related issue released Issue released publicly :tooltip Related to hover tooltip
Projects
None yet
Milestone
No milestone
3 participants
@markov00 @nickofthyme @rshen91